From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks Date: Mon, 21 Jan 2019 10:33:23 +0100 Message-ID: <20190121093323.GP3271@phenom.ffwll.local> References: <20190118231129.8281-1-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190118231129.8281-1-peda@axentia.se> Sender: linux-kernel-owner@vger.kernel.org To: Peter Rosin Cc: "linux-kernel@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org On Fri, Jan 18, 2019 at 11:11:38PM +0000, Peter Rosin wrote: > The gpio API explicitly allows skipping the NULL check, precisely to > allow for neat support for optional gpios. Which is exactly what is at > play here. > > Reported-by: Andrzej Hajda > Signed-off-by: Peter Rosin lgtm, Reviewed-by: Daniel Vetter btw plan to stick around a bit in drm land, i.e. want commit rights for drm-misc? -Daniel > --- > drivers/gpu/drm/bridge/lvds-encoder.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c > index 36d8557bc097..584007eaf6e1 100644 > --- a/drivers/gpu/drm/bridge/lvds-encoder.c > +++ b/drivers/gpu/drm/bridge/lvds-encoder.c > @@ -36,8 +36,7 @@ static void lvds_encoder_enable(struct drm_bridge *bridge) > struct lvds_encoder, > bridge); > > - if (lvds_encoder->powerdown_gpio) > - gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 0); > + gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 0); > } > > static void lvds_encoder_disable(struct drm_bridge *bridge) > @@ -46,8 +45,7 @@ static void lvds_encoder_disable(struct drm_bridge *bridge) > struct lvds_encoder, > bridge); > > - if (lvds_encoder->powerdown_gpio) > - gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 1); > + gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 1); > } > > static struct drm_bridge_funcs funcs = { > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch