From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 21 Jan 2019 13:59:52 +0000 Subject: [PATCH] drm/komeda: Fix a signedness bug Message-Id: <20190121135952.GA14103@kadam> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "James (Qian) Wang" Cc: David Airlie , Liviu Dudau , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org The mdev->irq value comes from platform_get_irq() so it can't be more than INT_MAX and if it's unsigned then it breaks the error handling in komeda_parse_dt(). Fixes: 29e56aec911d ("drm/komeda: Add DT parsing") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index a0bf7050037a..a52da6180c69 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -82,7 +82,7 @@ struct komeda_dev { struct clk *mclk; /** @irq: irq number */ - u32 irq; + int irq; int n_pipelines; struct komeda_pipeline *pipelines[KOMEDA_MAX_PIPELINES]; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/komeda: Fix a signedness bug Date: Mon, 21 Jan 2019 16:59:52 +0300 Message-ID: <20190121135952.GA14103@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7ED896E11D for ; Mon, 21 Jan 2019 14:00:27 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "James (Qian) Wang" Cc: David Airlie , Liviu Dudau , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIG1kZXYtPmlycSB2YWx1ZSBjb21lcyBmcm9tIHBsYXRmb3JtX2dldF9pcnEoKSBzbyBpdCBj YW4ndCBiZSBtb3JlCnRoYW4gSU5UX01BWCBhbmQgaWYgaXQncyB1bnNpZ25lZCB0aGVuIGl0IGJy ZWFrcyB0aGUgZXJyb3IgaGFuZGxpbmcgaW4Ka29tZWRhX3BhcnNlX2R0KCkuCgpGaXhlczogMjll NTZhZWM5MTFkICgiZHJtL2tvbWVkYTogQWRkIERUIHBhcnNpbmciKQpTaWduZWQtb2ZmLWJ5OiBE YW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Ci0tLQogZHJpdmVycy9ncHUv ZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZGV2LmggfCAyICstCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9kZXYuaCBiL2RyaXZlcnMvZ3B1L2RybS9h cm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Rldi5oCmluZGV4IGEwYmY3MDUwMDM3YS4uYTUyZGE2 MTgwYzY5IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tv bWVkYV9kZXYuaAorKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVk YV9kZXYuaApAQCAtODIsNyArODIsNyBAQCBzdHJ1Y3Qga29tZWRhX2RldiB7CiAJc3RydWN0IGNs ayAqbWNsazsKIAogCS8qKiBAaXJxOiBpcnEgbnVtYmVyICovCi0JdTMyIGlycTsKKwlpbnQgaXJx OwogCiAJaW50IG5fcGlwZWxpbmVzOwogCXN0cnVjdCBrb21lZGFfcGlwZWxpbmUgKnBpcGVsaW5l c1tLT01FREFfTUFYX1BJUEVMSU5FU107Ci0tIAoyLjE3LjEKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=