From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH v4 5/6] usb: musb: Add musb_clearb/w() interface Date: Mon, 21 Jan 2019 09:59:29 -0600 Message-ID: <20190121155929.GC30080@uda0271908> References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-6-git-send-email-min.guo@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1548073351-13739-6-git-send-email-min.guo@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: min.guo@mediatek.com Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-Id: linux-mediatek@lists.infradead.org Hi Min, On Mon, Jan 21, 2019 at 08:22:30PM +0800, min.guo@mediatek.com wrote: > From: Min Guo > > Delete the const attribute of addr parameter in readb/w/l hooks, these > changes are for implementing clearing W1C registers. > Replace musb_readb/w with musb_clearb/w to clear the interrupt status. > > Signed-off-by: Min Guo > --- > new patch based on v3: > --- > drivers/usb/musb/musb_core.c | 32 +++++++++++++++++++++++--------- > drivers/usb/musb/musb_core.h | 8 ++++++-- > drivers/usb/musb/musb_io.h | 8 +++++--- > drivers/usb/musb/musbhsdma.c | 3 +++ > drivers/usb/musb/sunxi.c | 4 ++-- > drivers/usb/musb/tusb6010.c | 2 +- > 6 files changed, 40 insertions(+), 17 deletions(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 2fe5225..5ef8848 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c [snip] > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > index b2394a7..7bf91cb 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c > @@ -286,6 +286,9 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > int_hsdma = musb_readb(mbase, MUSB_HSDMA_INTR); > > + /* clear pending interrupts by manual */ > + musb_clearb(musb->mregs, MUSB_HSDMA_INTR); > + Make musb_clearb/w() return the value of the _read() instead of _write(), so that we don't have to read twice here. The value of _write() is not used anyway. The change above can be: int_hsdma = musb_clearb(mbase, MUSB_HSDMA_INTR); Please see my comments in 6/6 for details. Regards, -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,5/6] usb: musb: Add musb_clearb/w() interface From: Bin Liu Message-Id: <20190121155929.GC30080@uda0271908> Date: Mon, 21 Jan 2019 09:59:29 -0600 To: min.guo@mediatek.com Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com List-ID: SGkgTWluLAoKT24gTW9uLCBKYW4gMjEsIDIwMTkgYXQgMDg6MjI6MzBQTSArMDgwMCwgbWluLmd1 b0BtZWRpYXRlay5jb20gd3JvdGU6Cj4gRnJvbTogTWluIEd1byA8bWluLmd1b0BtZWRpYXRlay5j b20+Cj4gCj4gRGVsZXRlIHRoZSBjb25zdCBhdHRyaWJ1dGUgb2YgYWRkciBwYXJhbWV0ZXIgaW4g cmVhZGIvdy9sIGhvb2tzLCB0aGVzZQo+IGNoYW5nZXMgYXJlIGZvciBpbXBsZW1lbnRpbmcgY2xl YXJpbmcgVzFDIHJlZ2lzdGVycy4KPiBSZXBsYWNlIG11c2JfcmVhZGIvdyB3aXRoIG11c2JfY2xl YXJiL3cgdG8gY2xlYXIgdGhlIGludGVycnVwdCBzdGF0dXMuCj4gCj4gU2lnbmVkLW9mZi1ieTog TWluIEd1byA8bWluLmd1b0BtZWRpYXRlay5jb20+Cj4gLS0tCj4gbmV3IHBhdGNoIGJhc2VkIG9u IHYzOgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9tdXNiL211c2JfY29yZS5jIHwgMzIgKysrKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0KPiAgZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuaCB8 ICA4ICsrKysrKy0tCj4gIGRyaXZlcnMvdXNiL211c2IvbXVzYl9pby5oICAgfCAgOCArKysrKy0t LQo+ICBkcml2ZXJzL3VzYi9tdXNiL211c2Joc2RtYS5jIHwgIDMgKysrCj4gIGRyaXZlcnMvdXNi L211c2Ivc3VueGkuYyAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvdXNiL211c2IvdHVzYjYwMTAu YyAgfCAgMiArLQo+ICA2IGZpbGVzIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDE3IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdXNiL211c2JfY29yZS5jIGIv ZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuYwo+IGluZGV4IDJmZTUyMjUuLjVlZjg4NDggMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMv dXNiL211c2IvbXVzYl9jb3JlLmMKCltzbmlwXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Iv bXVzYi9tdXNiaHNkbWEuYyBiL2RyaXZlcnMvdXNiL211c2IvbXVzYmhzZG1hLmMKPiBpbmRleCBi MjM5NGE3Li43YmY5MWNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL211c2IvbXVzYmhzZG1h LmMKPiArKysgYi9kcml2ZXJzL3VzYi9tdXNiL211c2Joc2RtYS5jCj4gQEAgLTI4Niw2ICsyODYs OSBAQCBpcnFyZXR1cm5fdCBkbWFfY29udHJvbGxlcl9pcnEoaW50IGlycSwgdm9pZCAqcHJpdmF0 ZV9kYXRhKQo+ICAKPiAgCWludF9oc2RtYSA9IG11c2JfcmVhZGIobWJhc2UsIE1VU0JfSFNETUFf SU5UUik7Cj4gIAo+ICsJLyogY2xlYXIgcGVuZGluZyBpbnRlcnJ1cHRzIGJ5IG1hbnVhbCAqLwo+ ICsJbXVzYl9jbGVhcmIobXVzYi0+bXJlZ3MsIE1VU0JfSFNETUFfSU5UUik7Cj4gKwoKTWFrZSBt dXNiX2NsZWFyYi93KCkgcmV0dXJuIHRoZSB2YWx1ZSBvZiB0aGUgX3JlYWQoKSBpbnN0ZWFkIG9m Cl93cml0ZSgpLCBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gcmVhZCB0d2ljZSBoZXJlLiBUaGUg dmFsdWUgb2YKX3dyaXRlKCkgaXMgbm90IHVzZWQgYW55d2F5LgoKVGhlIGNoYW5nZSBhYm92ZSBj YW4gYmU6CgoJaW50X2hzZG1hID0gbXVzYl9jbGVhcmIobWJhc2UsIE1VU0JfSFNETUFfSU5UUik7 CgpQbGVhc2Ugc2VlIG15IGNvbW1lbnRzIGluIDYvNiBmb3IgZGV0YWlscy4KClJlZ2FyZHMsCi1C aW4uCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731DCC2F421 for ; Mon, 21 Jan 2019 15:59:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1326320879 for ; Mon, 21 Jan 2019 15:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="prRKCex9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yUFsRucj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1326320879 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h6AkidgDSEpSbA/tvTHCCAc818RosuK1kA0NkYfoMA4=; b=prRKCex9U7DcYn x+PsObfmi5kmjk/tBYgb9brbkob3xGFr8kqkFa2h4cKmvdx7cifhjZsASJ6gKd4pDMK+dPcVXobzK fKKjwVbx1InbWcDiJ54aVaCHHP3cuF0RxMCVmA2TFV6AOpyC96HaxMwfcoIeGuTY7t2338qMPGSwX xkoaWmjnlNMGQ5asq2qUjwYNbm/fDq057IT0UDQ8UVp4KPKtEm7n3+SL0YN9K21yMby4Yet3TO//v TTK2PDQEY/lPBO9Igl8zjkP0NH8gxcvqPDxIUaaGpIFyfWJKJtz/PZOw1Y9BiZfBqE0Z5m0/Engds 7LPAT++j9Ly3WCgzrdUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glbzG-0003aI-5V; Mon, 21 Jan 2019 15:59:46 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glbz8-0003Sz-1O; Mon, 21 Jan 2019 15:59:42 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0LFxT0r107484; Mon, 21 Jan 2019 09:59:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1548086369; bh=ZHPYsL2xkgsk70zv70n70ayT4Gz6Ev9RUwViMeg/gGo=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=yUFsRucjWrwpgVJzsPIsThNEoPsOzkv1qN9wfkyx/DGd0/e1B17HSyWiQE7cJLSAC BzBpLY79TYpW8IXDT8l7KzukDCH5lxCB9PmqL45sFI9TbWTdAQVUOrE09e/qQfFI7G /gIgdMxb9eaZqSKZfUX7Zp0kScmz6ji5q935vEfs= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0LFxTLh067437 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Jan 2019 09:59:29 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 21 Jan 2019 09:59:29 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 21 Jan 2019 09:59:29 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0LFxT47030421; Mon, 21 Jan 2019 09:59:29 -0600 Date: Mon, 21 Jan 2019 09:59:29 -0600 From: Bin Liu To: Subject: Re: [PATCH v4 5/6] usb: musb: Add musb_clearb/w() interface Message-ID: <20190121155929.GC30080@uda0271908> Mail-Followup-To: Bin Liu , min.guo@mediatek.com, Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-6-git-send-email-min.guo@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1548073351-13739-6-git-send-email-min.guo@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_075938_307112_19B92FC6 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, hdegoede@redhat.com, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Rob Herring , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Min, On Mon, Jan 21, 2019 at 08:22:30PM +0800, min.guo@mediatek.com wrote: > From: Min Guo > > Delete the const attribute of addr parameter in readb/w/l hooks, these > changes are for implementing clearing W1C registers. > Replace musb_readb/w with musb_clearb/w to clear the interrupt status. > > Signed-off-by: Min Guo > --- > new patch based on v3: > --- > drivers/usb/musb/musb_core.c | 32 +++++++++++++++++++++++--------- > drivers/usb/musb/musb_core.h | 8 ++++++-- > drivers/usb/musb/musb_io.h | 8 +++++--- > drivers/usb/musb/musbhsdma.c | 3 +++ > drivers/usb/musb/sunxi.c | 4 ++-- > drivers/usb/musb/tusb6010.c | 2 +- > 6 files changed, 40 insertions(+), 17 deletions(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 2fe5225..5ef8848 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c [snip] > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > index b2394a7..7bf91cb 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c > @@ -286,6 +286,9 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > int_hsdma = musb_readb(mbase, MUSB_HSDMA_INTR); > > + /* clear pending interrupts by manual */ > + musb_clearb(musb->mregs, MUSB_HSDMA_INTR); > + Make musb_clearb/w() return the value of the _read() instead of _write(), so that we don't have to read twice here. The value of _write() is not used anyway. The change above can be: int_hsdma = musb_clearb(mbase, MUSB_HSDMA_INTR); Please see my comments in 6/6 for details. Regards, -Bin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BAEC2F441 for ; Mon, 21 Jan 2019 15:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07FCE20844 for ; Mon, 21 Jan 2019 15:59:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yUFsRucj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730399AbfAUP7u (ORCPT ); Mon, 21 Jan 2019 10:59:50 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35044 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728761AbfAUP7t (ORCPT ); Mon, 21 Jan 2019 10:59:49 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0LFxT0r107484; Mon, 21 Jan 2019 09:59:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1548086369; bh=ZHPYsL2xkgsk70zv70n70ayT4Gz6Ev9RUwViMeg/gGo=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=yUFsRucjWrwpgVJzsPIsThNEoPsOzkv1qN9wfkyx/DGd0/e1B17HSyWiQE7cJLSAC BzBpLY79TYpW8IXDT8l7KzukDCH5lxCB9PmqL45sFI9TbWTdAQVUOrE09e/qQfFI7G /gIgdMxb9eaZqSKZfUX7Zp0kScmz6ji5q935vEfs= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0LFxTLh067437 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Jan 2019 09:59:29 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 21 Jan 2019 09:59:29 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 21 Jan 2019 09:59:29 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0LFxT47030421; Mon, 21 Jan 2019 09:59:29 -0600 Date: Mon, 21 Jan 2019 09:59:29 -0600 From: Bin Liu To: CC: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , , , , , , , , Subject: Re: [PATCH v4 5/6] usb: musb: Add musb_clearb/w() interface Message-ID: <20190121155929.GC30080@uda0271908> Mail-Followup-To: Bin Liu , min.guo@mediatek.com, Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tony@atomide.com, hdegoede@redhat.com References: <1548073351-13739-1-git-send-email-min.guo@mediatek.com> <1548073351-13739-6-git-send-email-min.guo@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1548073351-13739-6-git-send-email-min.guo@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Min, On Mon, Jan 21, 2019 at 08:22:30PM +0800, min.guo@mediatek.com wrote: > From: Min Guo > > Delete the const attribute of addr parameter in readb/w/l hooks, these > changes are for implementing clearing W1C registers. > Replace musb_readb/w with musb_clearb/w to clear the interrupt status. > > Signed-off-by: Min Guo > --- > new patch based on v3: > --- > drivers/usb/musb/musb_core.c | 32 +++++++++++++++++++++++--------- > drivers/usb/musb/musb_core.h | 8 ++++++-- > drivers/usb/musb/musb_io.h | 8 +++++--- > drivers/usb/musb/musbhsdma.c | 3 +++ > drivers/usb/musb/sunxi.c | 4 ++-- > drivers/usb/musb/tusb6010.c | 2 +- > 6 files changed, 40 insertions(+), 17 deletions(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 2fe5225..5ef8848 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c [snip] > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > index b2394a7..7bf91cb 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c > @@ -286,6 +286,9 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > int_hsdma = musb_readb(mbase, MUSB_HSDMA_INTR); > > + /* clear pending interrupts by manual */ > + musb_clearb(musb->mregs, MUSB_HSDMA_INTR); > + Make musb_clearb/w() return the value of the _read() instead of _write(), so that we don't have to read twice here. The value of _write() is not used anyway. The change above can be: int_hsdma = musb_clearb(mbase, MUSB_HSDMA_INTR); Please see my comments in 6/6 for details. Regards, -Bin.