From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC78C2F441 for ; Mon, 21 Jan 2019 16:35:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69B8C20870 for ; Mon, 21 Jan 2019 16:35:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="SrocerK7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbfAUQfJ (ORCPT ); Mon, 21 Jan 2019 11:35:09 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50541 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729130AbfAUQfJ (ORCPT ); Mon, 21 Jan 2019 11:35:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=89XXw1wScHXR/v/VnkwCVZIaChIuxvbuxpKSR716ZTs=; b=SrocerK7F94cWhmlJHFB0hs03kajFqtyupcqKnJEqfYDHPbHNFt4LgLvkDNuMPfI2ITzgOjyXaINGuEmqbjYw+by0TDE12Bm2U8aLpZE3wW5NejudE5h2m59hvkotNC3CDVN5GD1QfTP0LYPbqSjSE9JFdoZwRXXUsrMiV21hmQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1glcXS-0002mM-5E; Mon, 21 Jan 2019 17:35:06 +0100 Date: Mon, 21 Jan 2019 17:35:06 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only Message-ID: <20190121163506.GE8620@lunn.ch> References: <36a3f6a9-7f4c-7d51-05aa-71e847132102@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: > The state machine is a no-op before phy_start() has been called. > Therefore let's enable it in phy_start() only. In phy_start() > let's call phy_start_machine() instead of phy_trigger_machine(). > phy_start_machine is an alias for phy_trigger_machine but it makes > clearer that we start the state machine here instead of just > triggering a run. Hi Heiner Documentation/networking/phy.txt has a section "Doing it all yourself" It would be good to review that, and make sure that documentation is still valid. I'm not sure any MAC driver actually does do it all itself. So it might be worth reviewing the whole document and making updates to remove parts of the text. Andrew