From: Andrew Lunn <andrew@lunn.ch>
To: Daniele Orlandi <daniele@orlandi.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: DSA incompatible with TI CPSW device model in dual mac mode
Date: Mon, 21 Jan 2019 17:55:38 +0100 [thread overview]
Message-ID: <20190121165538.GG8620@lunn.ch> (raw)
In-Reply-To: <d6f8fd07-6131-1e2b-09a6-97ab8406496d@orlandi.com>
On Mon, Jan 21, 2019 at 03:57:32PM +0100, Daniele Orlandi wrote:
> On 20/01/19 18:30, Andrew Lunn wrote:
> >
> >Looking at Documentation/devicetree/bindings/net/cpsw.txt, your DSA
> >Ethernet phandle should point to cpsw_emac1: slave@1.
>
> Hi Andrew,
>
> Yes, that's what sounds logical, however that node does not become the
> parent device net class nodes:
>
> root@r600:/sys/class/net# ls -l
> [...]
> lrwxrwxrwx 1 root root 0 Jan 1 1970 eth0 ->
> ../../devices/platform/ocp/4a100000.ethernet/net/eth0
> lrwxrwxrwx 1 root root 0 Jan 1 1970 eth1 ->
> ../../devices/platform/ocp/4a100000.ethernet/net/eth1
> [...]
>
> root@r600:/sys/class/net# cd eth0
> root@r600:/sys/devices/platform/ocp/4a100000.ethernet/net/eth0# ls -l
> [...]
> lrwxrwxrwx 1 root root 0 Jan 1 1970 device ->
> ../../../4a100000.ethernet
> [...]
>
> root@r600:/sys/class/net# cd eth1
> root@r600:/sys/devices/platform/ocp/4a100000.ethernet/net/eth1# ls -l
> [...]
> lrwxrwxrwx 1 root root 0 Jan 1 1970 device ->
> ../../../4a100000.ethernet
> [...]
>
> > I don't know if this actually works, but i _think_ some people have used
> DSA with this
> >device.
>
> IMHO it should be the CPSW driver that should istantiate two separate
> devices, one for each cpsw_emacX node in the device tree.
>
> Do you think they could be receptive to such proposal?
Hi Danielse
I suggest you ask. Or post a patch.
CPSW does all sorts of things in odd ways. So i would always expect
trouble with this device. From what i hear, there is a new driver
being written for it, so hopefully that driver will be more normal and
easier to use.
Andrew
prev parent reply other threads:[~2019-01-21 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 23:09 DSA incompatible with TI CPSW device model in dual mac mode Daniele Orlandi
2019-01-20 17:30 ` Andrew Lunn
2019-01-21 14:57 ` Daniele Orlandi
2019-01-21 16:55 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121165538.GG8620@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniele@orlandi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.