From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D5FC31681 for ; Mon, 21 Jan 2019 17:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCBEE20879 for ; Mon, 21 Jan 2019 17:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1N8sAHvv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726575AbfAURKL (ORCPT ); Mon, 21 Jan 2019 12:10:11 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50613 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfAURKL (ORCPT ); Mon, 21 Jan 2019 12:10:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=iLMmkdUJvlcIx7f1gnitURItSCMeeUTcHwnQcBYkvk8=; b=1N8sAHvvONoGNjjLbsv+0JWI7gyh4SfoMF6mhKNMxINnmUm6uOBvkxmKUdWHznMuJ2k4uk5eP5n9HY24QbpruCL4uSCrGB9KJUoPYBHUwLvF41OP3mDNM03JLbdVFzIvV+8Mxn7zrMz1lKyecw13C/MYenWP70Aj2Kswy09ZN+0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gld5M-0003O4-LO; Mon, 21 Jan 2019 18:10:08 +0100 Date: Mon, 21 Jan 2019 18:10:08 +0100 From: Andrew Lunn To: Igor Russkikh Cc: "David S . Miller" , "netdev@vger.kernel.org" , Nikita Danilov Subject: Re: [PATCH net 4/5] net: aquantia: fixed instack structure overflow Message-ID: <20190121171008.GJ8620@lunn.ch> References: <0329de90095bb2eb1ae24c4c3ed2958cb5c125f8.1547878835.git.igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0329de90095bb2eb1ae24c4c3ed2958cb5c125f8.1547878835.git.igor.russkikh@aquantia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 21, 2019 at 02:53:51PM +0000, Igor Russkikh wrote: > This is a real stack undercorruption found by kasan build. > > The issue did no harm normally because it only overflowed > 2 bytes after `bitary` array which on most architectures > were mapped into `err` local. Hi Igor Since this is a real bug, please add a fixes: tag, and post it to net. Thanks Andrew