From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=EppU=P5=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B0FB5C31681
	for <netdev@archiver.kernel.org>; Mon, 21 Jan 2019 18:29:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 811F120989
	for <netdev@archiver.kernel.org>; Mon, 21 Jan 2019 18:29:32 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Sb7pfyFQ"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727856AbfAUS3b (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 21 Jan 2019 13:29:31 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:50787 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726244AbfAUS3b (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 21 Jan 2019 13:29:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124;
        h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=Z1819GKEgq2QzPRjFfQoDDGU7KYoluFwdewveyHnmEY=;
        b=Sb7pfyFQ88dwhsFLOfYkJZvxisg2epTdkwDjrjK8t/PpRxHj/1vHRNs7xqO+k924c+AD2NPmBhNyzFH+BB6h532txT7lvBlYoHMine8aJbBjBTtwsIAZz5XnNwoPJavyHCIuElPc8/VncOGsCyPkbyB8GboiygUpakv15z3pzZw=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2)
        (envelope-from <andrew@lunn.ch>)
        id 1gleK8-0004Pt-3L; Mon, 21 Jan 2019 19:29:28 +0100
Date:   Mon, 21 Jan 2019 19:29:28 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called
 from invalid state
Message-ID: <20190121182928.GC16212@lunn.ch>
References: <36a3f6a9-7f4c-7d51-05aa-71e847132102@gmail.com>
 <cc566aa7-27cd-67fb-ea4b-00ee84d3dd7b@gmail.com>
 <20190121164036.GF8620@lunn.ch>
 <85441436-49f3-82c0-d550-d4ffa423ae12@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <85441436-49f3-82c0-d550-d4ffa423ae12@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> For all invalid states phy_start() basically was a no-op. All it did was
> triggering a state machine run, but for all "running" states the poll
> loop was active anyway. And if called from PHY_DOWN, the state machine
> does nothing. Therefore I see no scenario where jumping to out would
> break anything.

Hi Heiner

It is useful to put this sort of analysis in the commit message. You
then won't get people like me asking about it.

     Andrew