From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/5] drm/i915/crt: split out
 intel_crt_present() to platform specific setup
Date: Mon, 21 Jan 2019 21:30:17 +0200
Message-ID: <20190121193017.GQ20097@intel.com>
References: <20190121142134.17434-1-jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5AA036EB00
 for <intel-gfx@lists.freedesktop.org>; Mon, 21 Jan 2019 19:30:21 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190121142134.17434-1-jani.nikula@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBKYW4gMjEsIDIwMTkgYXQgMDQ6MjE6MzBQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gV2l0aCBuZXcgcGxhdGZvcm1zIG5vdCBoYXZpbmcgQ1JUIHN1cHBvcnQgYW5kIG1vc3Qg
Y29uZGl0aW9ucyBpbgo+IGludGVsX2NydF9wcmVzZW50KCkgYmVpbmcgc3BlY2lmaWMgdG8gRERJ
LCBzcGxpdCBvdXQgdGhlIENSVAo+IGluaXRpYWxpemF0aW9uIHRvIHBsYXRmb3JtIHNwZWNpZmlj
IGJsb2NrcyBpbiB0aGUgaWYgbGFkZGVyLiBBZGQgbmV3Cj4gUGluZXZpZXcgYmxvY2sgZm9yIHRo
aXMuCj4gCj4gVGhpcyBwdXRzIGludGVsX2NydF9pbml0KCkgbW9yZSBpbiBsaW5lIHdpdGggdGhl
IHJlc3Qgb2YgdGhlIG91dHB1dHMsCj4gYW5kIG1ha2VzIGl0IHNsaWdodGx5IGVhc2llciBmb3Ig
dGhlIHVuaW5pdGlhdGVkIHRvIGZpZ3VyZSBvdXQgd2hpY2gKPiBwbGF0Zm9ybXMgYWN0dWFsbHkg
aGF2ZSB3aGF0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp
bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8
IDM3ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI0IGlu
c2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMKPiBpbmRleCAyZmE5ZjRhZWMwOGUuLmU4YmMyOTdjNjBhYiAxMDA2NDQKPiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTQyNDUsMjMgKzE0MjQ1LDE3IEBAIHN0
YXRpYyBib29sIGhhc19lZHBfYShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g
IAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgaW50ZWxfY3J0X3ByZXNlbnQo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgYm9vbCBpbnRlbF9k
ZGlfY3J0X3ByZXNlbnQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4g
LQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+IC0JCXJldHVybiBmYWxzZTsKCldlIHNo
b3VsZCBwcm9iYWJseSBrZWVwIHRoaXMgaW4gY2FzZSB0aGUgdmJ0IGlzIGJvbmtlcnMuCgo+IC0K
PiAgCWlmIChJU19IU1dfVUxUKGRldl9wcml2KSB8fCBJU19CRFdfVUxUKGRldl9wcml2KSkKPiAg
CQlyZXR1cm4gZmFsc2U7Cj4gIAo+IC0JaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+IC0J
CXJldHVybiBmYWxzZTsKPiAtCj4gIAlpZiAoSEFTX1BDSF9MUFRfSChkZXZfcHJpdikgJiYKPiAg
CSAgICBJOTE1X1JFQUQoU0ZVU0VfU1RSQVApICYgU0ZVU0VfU1RSQVBfQ1JUX0RJU0FCTEVEKQo+
ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gIAkvKiBEREkgRSBjYW4ndCBiZSB1c2VkIGlmIERESSBB
IHJlcXVpcmVzIDQgbGFuZXMgKi8KPiAtCWlmIChIQVNfRERJKGRldl9wcml2KSAmJiBJOTE1X1JF
QUQoRERJX0JVRl9DVEwoUE9SVF9BKSkgJiBERElfQV80X0xBTkVTKQo+ICsJaWYgKEk5MTVfUkVB
RChERElfQlVGX0NUTChQT1JUX0EpKSAmIERESV9BXzRfTEFORVMpCj4gIAkJcmV0dXJuIGZhbHNl
Owo+ICAKPiAgCWlmICghZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4gQEAgLTE0MzIz
LDkgKzE0MzE3LDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkgKi8KPiAgCWludGVsX2x2ZHNfaW5pdChkZXZf
cHJpdik7Cj4gIAo+IC0JaWYgKGludGVsX2NydF9wcmVzZW50KGRldl9wcml2KSkKPiAtCQlpbnRl
bF9jcnRfaW5pdChkZXZfcHJpdik7Cj4gLQo+ICAJaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7
Cj4gIAkJaW50ZWxfZGRpX2luaXQoZGV2X3ByaXYsIFBPUlRfQSk7Cj4gIAkJaW50ZWxfZGRpX2lu
aXQoZGV2X3ByaXYsIFBPUlRfQik7Cj4gQEAgLTE0MzU0LDYgKzE0MzQ1LDkgQEAgc3RhdGljIHZv
aWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp
Cj4gIAl9IGVsc2UgaWYgKEhBU19EREkoZGV2X3ByaXYpKSB7Cj4gIAkJaW50IGZvdW5kOwo+ICAK
PiArCQlpZiAoaW50ZWxfZGRpX2NydF9wcmVzZW50KGRldl9wcml2KSkKPiArCQkJaW50ZWxfY3J0
X2luaXQoZGV2X3ByaXYpOwo+ICsKPiAgCQkvKgo+ICAJCSAqIEhhc3dlbGwgdXNlcyBEREkgZnVu
Y3Rpb25zIHRvIGRldGVjdCBkaWdpdGFsIG91dHB1dHMuCj4gIAkJICogT24gU0tMIHByZS1EMCB0
aGUgc3RyYXAgaXNuJ3QgY29ubmVjdGVkLCBzbyB3ZSBhc3N1bWUKPiBAQCAtMTQzODUsNiArMTQz
NzksMTAgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJfSBlbHNlIGlmIChIQVNfUENIX1NQTElUKGRldl9w
cml2KSkgewo+ICAJCWludCBmb3VuZDsKPiArCj4gKwkJaWYgKGRldl9wcml2LT52YnQuaW50X2Ny
dF9zdXBwb3J0KQo+ICsJCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4gKwo+ICAJCWRwZF9p
c19lZHAgPSBpbnRlbF9kcF9pc19wb3J0X2VkcChkZXZfcHJpdiwgUE9SVF9EKTsKPiAgCj4gIAkJ
aWYgKGhhc19lZHBfYShkZXZfcHJpdikpCj4gQEAgLTE0NDEzLDYgKzE0NDExLDkgQEAgc3RhdGlj
IHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYpCj4gIAl9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJ
RVcoZGV2X3ByaXYpKSB7Cj4gIAkJYm9vbCBoYXNfZWRwLCBoYXNfcG9ydDsKPiAgCj4gKwkJaWYg
KElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpICYmIGRldl9wcml2LT52YnQuaW50X2NydF9zdXBwb3J0
KQo+ICsJCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4gKwo+ICAJCS8qCj4gIAkJICogVGhl
IERQX0RFVEVDVEVEIGJpdCBpcyB0aGUgbGF0Y2hlZCBzdGF0ZSBvZiB0aGUgRERDCj4gIAkJICog
U0RBIHBpbiBhdCBib290LiBIb3dldmVyIHNpbmNlIGVEUCBkb2Vzbid0IHJlcXVpcmUgRERDCj4g
QEAgLTE0NDU1LDkgKzE0NDU2LDE1IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCX0KPiAgCj4gIAkJdmx2X2Rz
aV9pbml0KGRldl9wcml2KTsKPiAtCX0gZWxzZSBpZiAoIUlTX0dFTihkZXZfcHJpdiwgMikgJiYg
IUlTX1BJTkVWSUVXKGRldl9wcml2KSkgewo+ICsJfSBlbHNlIGlmIChJU19QSU5FVklFVyhkZXZf
cHJpdikpIHsKPiArCQlpZiAoZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4gKwkJCWlu
dGVsX2NydF9pbml0KGRldl9wcml2KTsKPiArCX0gZWxzZSBpZiAoSVNfR0VOX1JBTkdFKGRldl9w
cml2LCAzLCA0KSkgewo+ICAJCWJvb2wgZm91bmQgPSBmYWxzZTsKPiAgCj4gKwkJaWYgKGRldl9w
cml2LT52YnQuaW50X2NydF9zdXBwb3J0KQo+ICsJCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7
Cj4gKwo+ICAJCWlmIChJOTE1X1JFQUQoR0VOM19TRFZPQikgJiBTRFZPX0RFVEVDVEVEKSB7Cj4g
IAkJCURSTV9ERUJVR19LTVMoInByb2JpbmcgU0RWT0JcbiIpOwo+ICAJCQlmb3VuZCA9IGludGVs
X3Nkdm9faW5pdChkZXZfcHJpdiwgR0VOM19TRFZPQiwgUE9SVF9CKTsKPiBAQCAtMTQ0ODksOCAr
MTQ0OTYsMTIgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJCWlmIChJU19HNFgoZGV2X3ByaXYpICYmIChJ
OTE1X1JFQUQoRFBfRCkgJiBEUF9ERVRFQ1RFRCkpCj4gIAkJCWludGVsX2RwX2luaXQoZGV2X3By
aXYsIERQX0QsIFBPUlRfRCk7Cj4gLQl9IGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgMikpCj4g
Kwl9IGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgMikpIHsKPiArCQlpZiAoZGV2X3ByaXYtPnZi
dC5pbnRfY3J0X3N1cHBvcnQpCj4gKwkJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKCmludF9j
cnRfc3VwcG9ydCBpcyBhbHdheXMgdHJ1ZSBmb3IgcHJlLXZsdi9wcmUtaHN3IHNvIHdlIGNvdWxk
CnNraXAgdGhlIGNoZWNrIGluIG1vc3Qgb2YgdGhlc2UgY2FzZXMuIEVpdGhlciB3YXkgaXMgZmlu
ZSBieSBtZS4KCldpdGggdGhlIGdlbjkgc3R1ZmYgc29ydGVkIHRoaXMgaXMKUmV2aWV3ZWQtYnk6
IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICsKPiAg
CQlpbnRlbF9kdm9faW5pdChkZXZfcHJpdik7Cj4gKwl9Cj4gIAo+ICAJaWYgKFNVUFBPUlRTX1RW
KGRldl9wcml2KSkKPiAgCQlpbnRlbF90dl9pbml0KGRldl9wcml2KTsKPiAtLSAKPiAyLjIwLjEK
PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu
dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK
Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==