From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/5] drm/i915/lvds: only call intel_lvds_init() on platforms that might have LVDS Date: Mon, 21 Jan 2019 21:30:35 +0200 Message-ID: <20190121193035.GR20097@intel.com> References: <20190121142134.17434-1-jani.nikula@intel.com> <20190121142134.17434-2-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 934276EB02 for ; Mon, 21 Jan 2019 19:30:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190121142134.17434-2-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMjEsIDIwMTkgYXQgMDQ6MjE6MzFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2l0aCBuZXcgcGxhdGZvcm1zIG5vdCBoYXZpbmcgTFZEUyBzdXBwb3J0LCBvbmx5IGNh bGwgaW50ZWxfbHZkc19pbml0KCkKPiBvbiBwbGF0Zm9ybXMgdGhhdCBtaWdodCBhY3R1YWxseSBo YXZlIExWRFMuIE1vdmUgdGhlIGNvbW1lbnQgYWJvdXQgZURQCj4gaW5pdCB0byB0aGUgUENIIGJs b2NrIHdoZXJlIGl0J3MgcmVsZXZhbnQuCj4gCj4gVGhpcyBwdXRzIGludGVsX2x2ZHNfaW5pdCgp IG1vcmUgaW4gbGluZSB3aXRoIHRoZSByZXN0IG9mIHRoZSBvdXRwdXRzLAo+IGFuZCBtYWtlcyBp dCBzbGlnaHRseSBlYXNpZXIgZm9yIHRoZSB1bmluaXRpYXRlZCB0byBmaWd1cmUgb3V0IHdoaWNo Cj4gcGxhdGZvcm1zIGFjdHVhbGx5IGhhdmUgd2hhdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMCArKysrKysrKysrKysrLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZThiYzI5N2M2MGFiLi40YjU3MDRh ODc5MzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTE0MzEw LDEzICsxNDMxMCw2IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaWYgKCFIQVNfRElTUExBWShkZXZfcHJpdikp Cj4gIAkJcmV0dXJuOwo+ICAKPiAtCS8qCj4gLQkgKiBpbnRlbF9lZHBfaW5pdF9jb25uZWN0b3Io KSBkZXBlbmRzIG9uIHRoaXMgY29tcGxldGluZyBmaXJzdCwgdG8KPiAtCSAqIHByZXZlbnQgdGhl IHJlZ2lzdGVyYXRpb24gb2YgYm90aCBlRFAgYW5kIExWRFMgYW5kIHRoZSBpbmNvcnJlY3QKPiAt CSAqIHNoYXJpbmcgb2YgdGhlIFBQUy4KPiAtCSAqLwo+IC0JaW50ZWxfbHZkc19pbml0KGRldl9w cml2KTsKPiAtCj4gIAlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpIHsKPiAgCQlpbnRlbF9kZGlf aW5pdChkZXZfcHJpdiwgUE9SVF9BKTsKPiAgCQlpbnRlbF9kZGlfaW5pdChkZXZfcHJpdiwgUE9S VF9CKTsKPiBAQCAtMTQzODAsNiArMTQzNzMsMTMgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBf b3V0cHV0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAl9IGVsc2UgaWYg KEhBU19QQ0hfU1BMSVQoZGV2X3ByaXYpKSB7Cj4gIAkJaW50IGZvdW5kOwo+ICAKPiArCQkvKgo+ ICsJCSAqIGludGVsX2VkcF9pbml0X2Nvbm5lY3RvcigpIGRlcGVuZHMgb24gdGhpcyBjb21wbGV0 aW5nIGZpcnN0LAo+ICsJCSAqIHRvIHByZXZlbnQgdGhlIHJlZ2lzdHJhdGlvbiBvZiBib3RoIGVE UCBhbmQgTFZEUyBhbmQgdGhlCj4gKwkJICogaW5jb3JyZWN0IHNoYXJpbmcgb2YgdGhlIFBQUy4K PiArCQkgKi8KPiArCQlpbnRlbF9sdmRzX2luaXQoZGV2X3ByaXYpOwo+ICsKPiAgCQlpZiAoZGV2 X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4gIAkJCWludGVsX2NydF9pbml0KGRldl9wcml2 KTsKPiAgCj4gQEAgLTE0NDU3LDExICsxNDQ1NywxNSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXR1 cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAkJdmx2 X2RzaV9pbml0KGRldl9wcml2KTsKPiAgCX0gZWxzZSBpZiAoSVNfUElORVZJRVcoZGV2X3ByaXYp KSB7Cj4gKwkJaW50ZWxfbHZkc19pbml0KGRldl9wcml2KTsKPiArCj4gIAkJaWYgKGRldl9wcml2 LT52YnQuaW50X2NydF9zdXBwb3J0KQo+ICAJCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4g IAl9IGVsc2UgaWYgKElTX0dFTl9SQU5HRShkZXZfcHJpdiwgMywgNCkpIHsKPiAgCQlib29sIGZv dW5kID0gZmFsc2U7Cj4gIAo+ICsJCWludGVsX2x2ZHNfaW5pdChkZXZfcHJpdik7Cj4gKwo+ICAJ CWlmIChkZXZfcHJpdi0+dmJ0LmludF9jcnRfc3VwcG9ydCkKPiAgCQkJaW50ZWxfY3J0X2luaXQo ZGV2X3ByaXYpOwo+ICAKPiBAQCAtMTQ0OTcsNiArMTQ1MDEsOCBAQCBzdGF0aWMgdm9pZCBpbnRl bF9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlp ZiAoSVNfRzRYKGRldl9wcml2KSAmJiAoSTkxNV9SRUFEKERQX0QpICYgRFBfREVURUNURUQpKQo+ ICAJCQlpbnRlbF9kcF9pbml0KGRldl9wcml2LCBEUF9ELCBQT1JUX0QpOwo+ICAJfSBlbHNlIGlm IChJU19HRU4oZGV2X3ByaXYsIDIpKSB7Cj4gKwkJaW50ZWxfbHZkc19pbml0KGRldl9wcml2KTsK PiArCj4gIAkJaWYgKGRldl9wcml2LT52YnQuaW50X2NydF9zdXBwb3J0KQo+ICAJCQlpbnRlbF9j cnRfaW5pdChkZXZfcHJpdik7Cj4gIAo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK