From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Wei Xu" <wexu@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition
Date: Tue, 22 Jan 2019 00:05:20 -0500 [thread overview]
Message-ID: <20190122000452-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c52c29be-f285-2e5c-24ce-352c284e2b58@redhat.com>
On Tue, Jan 22, 2019 at 05:28:12AM +0100, Thomas Huth wrote:
> On 2019-01-21 20:46, Philippe Mathieu-Daudé wrote:
> > On 1/21/19 8:22 PM, Eric Blake wrote:
> >> On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote:
> >>> Commit 2974e916df8 introduced the VirtioNetRscChain structure which
> >>> refer to a VirtIONet, declared later, thus required VirtIONet typedef
> >>> to be declarated forward.
> >>
> >> s/be declarated forward/use a forward declaration/
> >
> > Thanks Eric.
> >
> > Thomas, do you mind fixing this if you take this patch?
>
> No problem, just fixed it while picking up the patch.
>
> Thanks,
> Thomas
>
I'm not sure why it's going through that tree but sure go ahead.
Sent Reviewed-by tag.
next prev parent reply other threads:[~2019-01-22 5:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 18:10 [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition Philippe Mathieu-Daudé
2019-01-21 19:22 ` Eric Blake
2019-01-21 19:46 ` Philippe Mathieu-Daudé
2019-01-22 4:28 ` Thomas Huth
2019-01-22 5:05 ` Michael S. Tsirkin [this message]
2019-01-22 5:23 ` Thomas Huth
2019-01-22 13:55 ` Michael S. Tsirkin
2019-01-21 21:53 ` Greg Kurz
2019-01-22 5:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122000452-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wexu@redhat.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.