From: Phillip Potter <phil@philpotter.co.uk>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, amir73il@gmail.com, viro@zeniv.linux.org.uk,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH v5 07/09] ext4: use common file type conversion
Date: Tue, 22 Jan 2019 10:00:16 +0000 [thread overview]
Message-ID: <20190122100016.GB3245@pathfinder> (raw)
In-Reply-To: <20190121142048.GB21694@quack2.suse.cz>
On Mon, Jan 21, 2019 at 03:20:48PM +0100, Jan Kara wrote:
> On Mon 21-01-19 00:54:35, Phillip Potter wrote:
> > Deduplicate the ext4 file type conversion implementation and define
> > EXT4_FT_* to match shared FT_* - file systems that use the same file
> > types as defined by POSIX do not need to define their own versions
> > and can use the common helper functions decared in fs_types.h and
> > implemented in fs_types.c
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>
> Looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>
Dear Jan,
Thank you for this, much appreciated.
Regards,
Phil
prev parent reply other threads:[~2019-01-22 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 0:54 [RFC][PATCH v5 07/09] ext4: use common file type conversion Phillip Potter
2019-01-21 14:20 ` Jan Kara
2019-01-22 10:00 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122100016.GB3245@pathfinder \
--to=phil@philpotter.co.uk \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.