Re: [PATCH v3 2/2] mtd: rework partitions handling

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <bbrezillon@kernel.org>
Cc: Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 2/2] mtd: rework partitions handling
Date: Tue, 22 Jan 2019 12:12:36 +0100	[thread overview]
Message-ID: <20190122121236.341d22f4@xps13> (raw)
In-Reply-To: <20190117212916.70ad1269@bbrezillon>

Hi Boris,

> >  int mtd_block_markbad(struct mtd_info *mtd, loff_t ofs)
> >  {
> > -	if (!mtd->_block_markbad)
> > +	struct mtd_info *master = mtd_get_master(mtd);
> > +	int ret;
> > +
> > +	if (!master->_block_markbad)
> >  		return -EOPNOTSUPP;
> >  	if (ofs < 0 || ofs >= mtd->size)
> >  		return -EINVAL;
> >  	if (!(mtd->flags & MTD_WRITEABLE))
> >  		return -EROFS;
> > -	return mtd->_block_markbad(mtd, ofs);
> > +
> > +	ret = master->_block_markbad(master, mtd_get_master_offset(mtd, ofs));
> > +	if (ret)
> > +		return ret;
> > +
> > +	while (mtd->parent) {
> > +		mtd->ecc_stats.badblocks++;
> > +		mtd = mtd->parent;
> > +	}  
> 
> Not exactly related to this patch, but if we mark a block bad on the
> master device this information is not propagated to parts exposing this
> block.

No but is this important? It is very quick to get up to the master
device so the penalty for doing that is almost non-existent.

Other comments addressed, thanks for the review.
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/