From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Zhiwei Jiang <qq282012236@gmail.com>
Cc: kbuild-all@01.org, qq282012236@gmail.com,
ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org,
davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
Date: Tue, 22 Jan 2019 15:59:02 +0300 [thread overview]
Message-ID: <20190122125902.GD11828@kadam> (raw)
In-Reply-To: <20190119105530.6079-1-qq282012236@gmail.com>
Hi Zhiwei,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Zhiwei-Jiang/ath-move-spin_lock_bh-to-spin_lock-in-tasklet/20190121-185529
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
smatch warnings:
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:584 ath9k_tx_failed_tasklet() warn: inconsistent returns 'bottom_half:'.
Locked on: line 584
Unlocked on: line 580
# https://github.com/0day-ci/linux/commit/953929a8fc22ae7ab9adafed62c84a11c4be2270
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 953929a8fc22ae7ab9adafed62c84a11c4be2270
vim +584 drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
27876a29 Sujith Manoharan 2011-04-13 572
27876a29 Sujith Manoharan 2011-04-13 573 void ath9k_tx_failed_tasklet(unsigned long data)
27876a29 Sujith Manoharan 2011-04-13 574 {
27876a29 Sujith Manoharan 2011-04-13 575 struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
b587fc81 Sujith Manoharan 2011-04-13 576
953929a8 Zhiwei Jiang 2019-01-19 577 spin_lock(&priv->tx.tx_lock);
27876a29 Sujith Manoharan 2011-04-13 578 if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
27876a29 Sujith Manoharan 2011-04-13 579 spin_unlock_bh(&priv->tx.tx_lock);
^^^
Missed this one.
27876a29 Sujith Manoharan 2011-04-13 580 return;
b587fc81 Sujith Manoharan 2011-04-13 581 }
953929a8 Zhiwei Jiang 2019-01-19 582 spin_unlock(&priv->tx.tx_lock);
b587fc81 Sujith Manoharan 2011-04-13 583
27876a29 Sujith Manoharan 2011-04-13 @584 ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
b587fc81 Sujith Manoharan 2011-04-13 585 }
27876a29 Sujith Manoharan 2011-04-13 586
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-01-22 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 10:55 [PATCH] ath: move spin_lock_bh to spin_lock in tasklet Zhiwei Jiang
2019-01-22 12:59 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-22 16:30 Zhiwei Jiang
2019-01-22 16:42 ` Kalle Valo
[not found] ` <CANHzP_uiEoYaSg4fC1gHHjc=gRLjaxt8S3=p6a-rkg5-WjR7MA@mail.gmail.com>
2019-01-23 4:25 ` Kalle Valo
2019-02-07 15:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122125902.GD11828@kadam \
--to=dan.carpenter@oracle.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qq282012236@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.