From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 22 Jan 2019 15:21:14 +0000 Subject: [PATCH] fbdev: omap2: no need to check return value of debugfs_create functions Message-Id: <20190122152151.16139-15-gregkh@linuxfoundation.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , linux-omap@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Bartlomiej Zolnierkiewicz Cc: Mauro Carvalho Chehab Cc: linux-omap@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 31 ++++----------------- drivers/video/fbdev/omap2/omapfb/dss/dss.h | 2 +- 2 files changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index b4bcf3a4a647..7e6a3eb266d0 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -110,19 +110,12 @@ DEFINE_SHOW_ATTRIBUTE(dss); static struct dentry *dss_debugfs_dir; -static int dss_initialize_debugfs(void) +static void dss_initialize_debugfs(void) { dss_debugfs_dir = debugfs_create_dir("omapdss", NULL); - if (IS_ERR(dss_debugfs_dir)) { - int err = PTR_ERR(dss_debugfs_dir); - dss_debugfs_dir = NULL; - return err; - } debugfs_create_file("clk", S_IRUGO, dss_debugfs_dir, &dss_debug_dump_clocks, &dss_fops); - - return 0; } static void dss_uninitialize_debugfs(void) @@ -130,24 +123,18 @@ static void dss_uninitialize_debugfs(void) debugfs_remove_recursive(dss_debugfs_dir); } -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - struct dentry *d; - - d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, - write, &dss_fops); - - return PTR_ERR_OR_ZERO(d); + debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, write, &dss_fops); } #else /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ -static inline int dss_initialize_debugfs(void) +static inline void dss_initialize_debugfs(void) { - return 0; } static inline void dss_uninitialize_debugfs(void) { } -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { return 0; } @@ -188,9 +175,7 @@ static int __init omap_dss_probe(struct platform_device *pdev) dss_features_init(omapdss_get_version()); - r = dss_initialize_debugfs(); - if (r) - goto err_debugfs; + dss_initialize_debugfs(); if (def_disp_name) core.default_display_name = def_disp_name; @@ -198,10 +183,6 @@ static int __init omap_dss_probe(struct platform_device *pdev) register_pm_notifier(&omap_dss_pm_notif_block); return 0; - -err_debugfs: - - return r; } static int omap_dss_remove(struct platform_device *pdev) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.h b/drivers/video/fbdev/omap2/omapfb/dss/dss.h index a3cc0ca8f9d2..b1a354494144 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.h +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.h @@ -214,7 +214,7 @@ struct platform_device *dss_get_core_pdev(void); int dss_dsi_enable_pads(int dsi_id, unsigned lane_mask); void dss_dsi_disable_pads(int dsi_id, unsigned lane_mask); int dss_set_min_bus_tput(struct device *dev, unsigned long tput); -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)); +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)); /* display */ int dss_suspend_all_devices(void); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH] fbdev: omap2: no need to check return value of debugfs_create functions Date: Tue, 22 Jan 2019 16:21:14 +0100 Message-ID: <20190122152151.16139-15-gregkh@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBz YW1zdW5nLmNvbT4KQ2M6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhhYitzYW1zdW5nQGtl cm5lbC5vcmc+CkNjOiBsaW51eC1vbWFwQHZnZXIua2VybmVsLm9yZwpDYzogbGludXgtZmJkZXZA dmdlci5rZXJuZWwub3JnCkNjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnClNpZ25l ZC1vZmYtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+ Ci0tLQogZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL2NvcmUuYyB8IDMxICsr KystLS0tLS0tLS0tLS0tLS0tLQogZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNz L2Rzcy5oICB8ICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMjYgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIv ZHNzL2NvcmUuYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9jb3JlLmMK aW5kZXggYjRiY2YzYTRhNjQ3Li43ZTZhM2ViMjY2ZDAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdmlk ZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9jb3JlLmMKKysrIGIvZHJpdmVycy92aWRlby9mYmRl di9vbWFwMi9vbWFwZmIvZHNzL2NvcmUuYwpAQCAtMTEwLDE5ICsxMTAsMTIgQEAgREVGSU5FX1NI T1dfQVRUUklCVVRFKGRzcyk7CiAKIHN0YXRpYyBzdHJ1Y3QgZGVudHJ5ICpkc3NfZGVidWdmc19k aXI7CiAKLXN0YXRpYyBpbnQgZHNzX2luaXRpYWxpemVfZGVidWdmcyh2b2lkKQorc3RhdGljIHZv aWQgZHNzX2luaXRpYWxpemVfZGVidWdmcyh2b2lkKQogewogCWRzc19kZWJ1Z2ZzX2RpciA9IGRl YnVnZnNfY3JlYXRlX2Rpcigib21hcGRzcyIsIE5VTEwpOwotCWlmIChJU19FUlIoZHNzX2RlYnVn ZnNfZGlyKSkgewotCQlpbnQgZXJyID0gUFRSX0VSUihkc3NfZGVidWdmc19kaXIpOwotCQlkc3Nf ZGVidWdmc19kaXIgPSBOVUxMOwotCQlyZXR1cm4gZXJyOwotCX0KIAogCWRlYnVnZnNfY3JlYXRl X2ZpbGUoImNsayIsIFNfSVJVR08sIGRzc19kZWJ1Z2ZzX2RpciwKIAkJCSZkc3NfZGVidWdfZHVt cF9jbG9ja3MsICZkc3NfZm9wcyk7Ci0KLQlyZXR1cm4gMDsKIH0KIAogc3RhdGljIHZvaWQgZHNz X3VuaW5pdGlhbGl6ZV9kZWJ1Z2ZzKHZvaWQpCkBAIC0xMzAsMjQgKzEyMywxOCBAQCBzdGF0aWMg dm9pZCBkc3NfdW5pbml0aWFsaXplX2RlYnVnZnModm9pZCkKIAlkZWJ1Z2ZzX3JlbW92ZV9yZWN1 cnNpdmUoZHNzX2RlYnVnZnNfZGlyKTsKIH0KIAotaW50IGRzc19kZWJ1Z2ZzX2NyZWF0ZV9maWxl KGNvbnN0IGNoYXIgKm5hbWUsIHZvaWQgKCp3cml0ZSkoc3RydWN0IHNlcV9maWxlICopKQordm9p ZCBkc3NfZGVidWdmc19jcmVhdGVfZmlsZShjb25zdCBjaGFyICpuYW1lLCB2b2lkICgqd3JpdGUp KHN0cnVjdCBzZXFfZmlsZSAqKSkKIHsKLQlzdHJ1Y3QgZGVudHJ5ICpkOwotCi0JZCA9IGRlYnVn ZnNfY3JlYXRlX2ZpbGUobmFtZSwgU19JUlVHTywgZHNzX2RlYnVnZnNfZGlyLAotCQkJd3JpdGUs ICZkc3NfZm9wcyk7Ci0KLQlyZXR1cm4gUFRSX0VSUl9PUl9aRVJPKGQpOworCWRlYnVnZnNfY3Jl YXRlX2ZpbGUobmFtZSwgU19JUlVHTywgZHNzX2RlYnVnZnNfZGlyLCB3cml0ZSwgJmRzc19mb3Bz KTsKIH0KICNlbHNlIC8qIENPTkZJR19GQl9PTUFQMl9EU1NfREVCVUdGUyAqLwotc3RhdGljIGlu bGluZSBpbnQgZHNzX2luaXRpYWxpemVfZGVidWdmcyh2b2lkKQorc3RhdGljIGlubGluZSB2b2lk IGRzc19pbml0aWFsaXplX2RlYnVnZnModm9pZCkKIHsKLQlyZXR1cm4gMDsKIH0KIHN0YXRpYyBp bmxpbmUgdm9pZCBkc3NfdW5pbml0aWFsaXplX2RlYnVnZnModm9pZCkKIHsKIH0KLWludCBkc3Nf ZGVidWdmc19jcmVhdGVfZmlsZShjb25zdCBjaGFyICpuYW1lLCB2b2lkICgqd3JpdGUpKHN0cnVj dCBzZXFfZmlsZSAqKSkKK3ZvaWQgZHNzX2RlYnVnZnNfY3JlYXRlX2ZpbGUoY29uc3QgY2hhciAq bmFtZSwgdm9pZCAoKndyaXRlKShzdHJ1Y3Qgc2VxX2ZpbGUgKikpCiB7CiAJcmV0dXJuIDA7CiB9 CkBAIC0xODgsOSArMTc1LDcgQEAgc3RhdGljIGludCBfX2luaXQgb21hcF9kc3NfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAogCWRzc19mZWF0dXJlc19pbml0KG9tYXBkc3Nf Z2V0X3ZlcnNpb24oKSk7CiAKLQlyID0gZHNzX2luaXRpYWxpemVfZGVidWdmcygpOwotCWlmIChy KQotCQlnb3RvIGVycl9kZWJ1Z2ZzOworCWRzc19pbml0aWFsaXplX2RlYnVnZnMoKTsKIAogCWlm IChkZWZfZGlzcF9uYW1lKQogCQljb3JlLmRlZmF1bHRfZGlzcGxheV9uYW1lID0gZGVmX2Rpc3Bf bmFtZTsKQEAgLTE5OCwxMCArMTgzLDYgQEAgc3RhdGljIGludCBfX2luaXQgb21hcF9kc3NfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlyZWdpc3Rlcl9wbV9ub3RpZmllcigm b21hcF9kc3NfcG1fbm90aWZfYmxvY2spOwogCiAJcmV0dXJuIDA7Ci0KLWVycl9kZWJ1Z2ZzOgot Ci0JcmV0dXJuIHI7CiB9CiAKIHN0YXRpYyBpbnQgb21hcF9kc3NfcmVtb3ZlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9kc3MvZHNzLmggYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3Mv ZHNzLmgKaW5kZXggYTNjYzBjYThmOWQyLi5iMWEzNTQ0OTQxNDQgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kc3MuaAorKysgYi9kcml2ZXJzL3ZpZGVv L2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvZHNzLmgKQEAgLTIxNCw3ICsyMTQsNyBAQCBzdHJ1Y3Qg cGxhdGZvcm1fZGV2aWNlICpkc3NfZ2V0X2NvcmVfcGRldih2b2lkKTsKIGludCBkc3NfZHNpX2Vu YWJsZV9wYWRzKGludCBkc2lfaWQsIHVuc2lnbmVkIGxhbmVfbWFzayk7CiB2b2lkIGRzc19kc2lf ZGlzYWJsZV9wYWRzKGludCBkc2lfaWQsIHVuc2lnbmVkIGxhbmVfbWFzayk7CiBpbnQgZHNzX3Nl dF9taW5fYnVzX3RwdXQoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBsb25nIHRwdXQpOwot aW50IGRzc19kZWJ1Z2ZzX2NyZWF0ZV9maWxlKGNvbnN0IGNoYXIgKm5hbWUsIHZvaWQgKCp3cml0 ZSkoc3RydWN0IHNlcV9maWxlICopKTsKK3ZvaWQgZHNzX2RlYnVnZnNfY3JlYXRlX2ZpbGUoY29u c3QgY2hhciAqbmFtZSwgdm9pZCAoKndyaXRlKShzdHJ1Y3Qgc2VxX2ZpbGUgKikpOwogCiAvKiBk aXNwbGF5ICovCiBpbnQgZHNzX3N1c3BlbmRfYWxsX2RldmljZXModm9pZCk7Ci0tIAoyLjIwLjEK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23BBEC282C4 for ; Tue, 22 Jan 2019 15:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E62B121019 for ; Tue, 22 Jan 2019 15:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548170887; bh=cUgfs522aE0MgKuvWNDHEznVAK83DlFXNepH+6WZeVQ=; h=From:To:Cc:Subject:Date:List-ID:From; b=nn9L9jgQiFlBMOMZE+wQfJtlI5rtQdfnBi6QHcJic8Ddop5vLfx5aigxhGrFY1OoI NsvYQAEGm1+F7K23MxiBi34Lx5HseRHG3i3lF2EosfFCmTj62bKwTC3fjYupoQQqAi Fchsp0LIrOV11T184T1H7pikhCTh4P3K5APcAAnU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729544AbfAVPWU (ORCPT ); Tue, 22 Jan 2019 10:22:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:34348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729408AbfAVPWS (ORCPT ); Tue, 22 Jan 2019 10:22:18 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 888CC20879; Tue, 22 Jan 2019 15:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548170537; bh=cUgfs522aE0MgKuvWNDHEznVAK83DlFXNepH+6WZeVQ=; h=From:To:Cc:Subject:Date:From; b=v3SdoX5fEnfINnfXGJM8gSFpZoinZS5NO72OJU3VuVnJlp/JACxSiuIs042J+laXn Lmcq3JSPCwVQfy9Iq1B43IgogNOuCLMZyPbAvvDzfJAONWQ0FPW3IHsLFQ5YRGDbug RNHBAFVxao0OTvnWdmFaTOykpWXkGMMB6Y0moxAA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Mauro Carvalho Chehab , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] fbdev: omap2: no need to check return value of debugfs_create functions Date: Tue, 22 Jan 2019 16:21:14 +0100 Message-Id: <20190122152151.16139-15-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Bartlomiej Zolnierkiewicz Cc: Mauro Carvalho Chehab Cc: linux-omap@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 31 ++++----------------- drivers/video/fbdev/omap2/omapfb/dss/dss.h | 2 +- 2 files changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index b4bcf3a4a647..7e6a3eb266d0 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -110,19 +110,12 @@ DEFINE_SHOW_ATTRIBUTE(dss); static struct dentry *dss_debugfs_dir; -static int dss_initialize_debugfs(void) +static void dss_initialize_debugfs(void) { dss_debugfs_dir = debugfs_create_dir("omapdss", NULL); - if (IS_ERR(dss_debugfs_dir)) { - int err = PTR_ERR(dss_debugfs_dir); - dss_debugfs_dir = NULL; - return err; - } debugfs_create_file("clk", S_IRUGO, dss_debugfs_dir, &dss_debug_dump_clocks, &dss_fops); - - return 0; } static void dss_uninitialize_debugfs(void) @@ -130,24 +123,18 @@ static void dss_uninitialize_debugfs(void) debugfs_remove_recursive(dss_debugfs_dir); } -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - struct dentry *d; - - d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, - write, &dss_fops); - - return PTR_ERR_OR_ZERO(d); + debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, write, &dss_fops); } #else /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ -static inline int dss_initialize_debugfs(void) +static inline void dss_initialize_debugfs(void) { - return 0; } static inline void dss_uninitialize_debugfs(void) { } -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { return 0; } @@ -188,9 +175,7 @@ static int __init omap_dss_probe(struct platform_device *pdev) dss_features_init(omapdss_get_version()); - r = dss_initialize_debugfs(); - if (r) - goto err_debugfs; + dss_initialize_debugfs(); if (def_disp_name) core.default_display_name = def_disp_name; @@ -198,10 +183,6 @@ static int __init omap_dss_probe(struct platform_device *pdev) register_pm_notifier(&omap_dss_pm_notif_block); return 0; - -err_debugfs: - - return r; } static int omap_dss_remove(struct platform_device *pdev) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.h b/drivers/video/fbdev/omap2/omapfb/dss/dss.h index a3cc0ca8f9d2..b1a354494144 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.h +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.h @@ -214,7 +214,7 @@ struct platform_device *dss_get_core_pdev(void); int dss_dsi_enable_pads(int dsi_id, unsigned lane_mask); void dss_dsi_disable_pads(int dsi_id, unsigned lane_mask); int dss_set_min_bus_tput(struct device *dev, unsigned long tput); -int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)); +void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)); /* display */ int dss_suspend_all_devices(void); -- 2.20.1