From: Michal Hocko <mhocko@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Laura Abbott <labbott@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: no need to check return value of debugfs_create functions
Date: Tue, 22 Jan 2019 18:29:44 +0100 [thread overview]
Message-ID: <20190122172944.GL4087@dhcp22.suse.cz> (raw)
In-Reply-To: <20190122162749.GA22841@kroah.com>
On Tue 22-01-19 17:27:49, Greg KH wrote:
> On Tue, Jan 22, 2019 at 05:07:01PM +0100, Michal Hocko wrote:
[...]
> > sounds like a poor design goal to me but not mine code to maintain so...
>
> The design goal was to make it as simple as possible to use, and that
> includes "you do not care about the return value". Now we do have to
> return a value because some people need that for when they want to make
> a subdirectory, or remove the file later on, otherwise I would have just
> had everything be a void return function :)
I suspect that you are making assumptions which might change in the
future and this whole mess will be unfixable. But whatever I do not care
about debugfs at all.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-01-22 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] mm: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 15:31 ` Michal Hocko
2019-01-22 15:52 ` Greg Kroah-Hartman
2019-01-22 16:07 ` Michal Hocko
2019-01-22 16:27 ` Greg Kroah-Hartman
2019-01-22 17:29 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122172944.GL4087@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.