From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Joel Stanley" <joel@jms.id.au>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Urs Fässler" <urs.fassler@bbv.ch>,
"Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 0/6] add quartz load support to NXP rtc drivers
Date: Tue, 22 Jan 2019 18:57:52 +0100 [thread overview]
Message-ID: <20190122175752.GD16702@piout.net> (raw)
In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org>
On 19/01/2019 10:00:25+0100, Sam Ravnborg wrote:
> Respin of patchset on top of v5.0-rc2 with feedback addressed (thanks!)
>
> Introduce a new generic property "quartz-load-femtofarad"
> to specify the quartz load.
> The default value is selected to match the current Linux
> drivers, so there are no behavior changes if a binding do not
> specify the quarts-load.
> The unit is femtofarads because several RTC's define the quarts load
> in steps of 0.5 pF.
>
> The two drivers rtc-pcf8523 and rtc-pcf85063 are both
> updated to use the new binding.
> Previously pcf8523 hardcoded the quartz load to 12.5pF, and
> pcf85063 used the reset default of 7pF.
> With this patchset it can now be specified in the DT,
> if the defaults are not OK.
>
> The patch-set is tested on a proprietary board for both
> RTC variants (v2 variant only as there was only trivial changes in v3).
>
> Sam
>
> v3:
> - Document generic property "quartz-load-femtofarads" in rtc.txt (Rob)
> - Fix indent several places - ups (Alexandre)
> - Use the simpler name "rtc" in DT examples (Rob)
> - Collected "Reviewed by's"
>
> v2:
> - Introduce a generic property "quartz-load-femtofarads"
> - Add femtofarads to property-units.txt
> - Make the changes backward compatible
> - Reduced logging
> - Warn, when we continue with a default value
> - Tested, by Søren Andersen, on real HW
> - Rebased on top of v5.0-rc1
>
> Sam
>
> Sam Ravnborg (6):
> devicetree: property-units: Add femtofarads unit
> dt-bindings: rtc: Add quartz-load-femtofarads property
> dt-binding: pcf8523: add xtal load capacitance
> dt-binding: pcf85063: add xtal load capacitance
> rtc: pcf8523: set xtal load capacitance from DT
> rtc: pcf85063: set xtal load capacitance from DT
>
All applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-01-22 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 9:00 [PATCH v3 0/6] add quartz load support to NXP rtc drivers Sam Ravnborg
2019-01-19 9:00 ` [PATCH v3 1/6] devicetree: property-units: Add femtofarads unit Sam Ravnborg
2019-01-19 9:00 ` [PATCH v3 2/6] dt-bindings: rtc: Add quartz-load-femtofarads property Sam Ravnborg
2019-01-21 15:24 ` Rob Herring
2019-01-21 15:24 ` Rob Herring
2019-01-19 9:00 ` [PATCH v3 3/6] dt-binding: pcf8523: add xtal load capacitance Sam Ravnborg
2019-01-19 9:00 ` [PATCH v3 4/6] dt-binding: pcf85063: " Sam Ravnborg
2019-01-21 15:25 ` Rob Herring
2019-01-21 15:25 ` Rob Herring
2019-01-19 9:00 ` [PATCH v3 5/6] rtc: pcf8523: set xtal load capacitance from DT Sam Ravnborg
2019-01-19 9:00 ` [PATCH v3 6/6] rtc: pcf85063: " Sam Ravnborg
2019-01-22 17:57 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122175752.GD16702@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=urs.fassler@bbv.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.