From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Eric Wong <e@80x24.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Sylvain Chouleur <sylvain.chouleur@intel.com>,
Patrick McDermott <patrick.mcdermott@libiquity.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: cmos: ignore bogus century byte
Date: Tue, 22 Jan 2019 19:06:11 +0100 [thread overview]
Message-ID: <20190122180611.GG16702@piout.net> (raw)
In-Reply-To: <20190106082103.evfgarznrskd4oxh@dcvr>
On 06/01/2019 08:21:03+0000, Eric Wong wrote:
> Older versions of Libreboot and Coreboot had an invalid value
> (`3' in my case) in the century byte affecting the GM45 in
> the Thinkpad X200. Not everybody's updated their firmwares,
> and Linux <= 4.2 was able to read the RTC without problems,
> so workaround this by ignoring invalid values.
>
> Fixes: 3c217e51d8a272b9 ("rtc: cmos: century support")
>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Sylvain Chouleur <sylvain.chouleur@intel.com>
> Cc: Patrick McDermott <patrick.mcdermott@libiquity.com>
> Cc: linux-rtc@vger.kernel.org
> Signed-off-by: Eric Wong <e@80x24.org>
> ---
> drivers/rtc/rtc-mc146818-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-01-22 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 8:21 [PATCH] rtc: cmos: ignore bogus century byte Eric Wong
2019-01-10 21:33 ` Alexandre Belloni
2019-01-10 21:56 ` Eric Wong
2019-01-22 18:06 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122180611.GG16702@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=e@80x24.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=patrick.mcdermott@libiquity.com \
--cc=sylvain.chouleur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.