From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Sibi Sankar <sibis@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/10] arm64: dts: qcom: sdm845: Add Q6V5 MSS node
Date: Tue, 22 Jan 2019 17:10:22 -0800 [thread overview]
Message-ID: <20190123011022.GJ31919@minitux> (raw)
In-Reply-To: <CAD=FV=XuA0Sm0fXfaHtib7+rji1s3s_SmjHc6d_DbEQ1LROq+A@mail.gmail.com>
On Tue 22 Jan 16:28 PST 2019, Doug Anderson wrote:
> Hi,
>
> On Mon, Jan 21, 2019 at 9:52 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > From: Sibi Sankar <sibis@codeaurora.org>
> >
> > This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
> >
> > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> > Changes since v2:
> > - Picked up Sibi's patch
> > - Fixed reg to work with address/size-cells as 2
> >
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 58 ++++++++++++++++++++++++++++
> > 1 file changed, 58 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 5cc2615461da..78df5f1bce2d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -1617,6 +1617,64 @@
> > clock-names = "xo";
> > };
> >
> > + mss_pil: remoteproc@4080000 {
> > + compatible = "qcom,sdm845-mss-pil";
> > + reg = <0 0x04080000 0 0x408>, <0 0x04180000 0 0x48>;
> > + reg-names = "qdsp6", "rmb";
> > +
> > + interrupts-extended =
> > + <&intc GIC_SPI 266 IRQ_TYPE_EDGE_RISING>,
> > + <&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> > + <&modem_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> > + <&modem_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> > + <&modem_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> > + <&modem_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
> > + interrupt-names = "wdog", "fatal", "ready",
> > + "handover", "stop-ack",
> > + "shutdown-ack";
> > +
> > + clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
> > + <&gcc GCC_MSS_Q6_MEMNOC_AXI_CLK>,
> > + <&gcc GCC_BOOT_ROM_AHB_CLK>,
> > + <&gcc GCC_MSS_GPLL0_DIV_CLK_SRC>,
> > + <&gcc GCC_MSS_SNOC_AXI_CLK>,
> > + <&gcc GCC_MSS_MFAB_AXIS_CLK>,
> > + <&gcc GCC_PRNG_AHB_CLK>,
> > + <&rpmhcc RPMH_CXO_CLK>;
> > + clock-names = "iface", "bus", "mem", "gpll0_mss",
> > + "snoc_axi", "mnoc_axi", "prng", "xo";
> > +
> > + qcom,smem-states = <&modem_smp2p_out 0>;
> > + qcom,smem-state-names = "stop";
> > +
> > + resets = <&aoss_reset AOSS_CC_MSS_RESTART>,
> > + <&pdc_reset PDC_MODEM_SYNC_RESET>;
> > + reset-names = "mss_restart", "pdc_reset";
> > +
> > + qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>;
> > +
> > + power-domains = <&aoss_qmp AOSS_QMP_LS_MODEM>,
> > + <&rpmhpd SDM845_CX>,
> > + <&rpmhpd SDM845_MX>,
> > + <&rpmhpd SDM845_MSS>;
> > + power-domain-names = "load_state", "cx", "mx", "mss";
> > +
> > + mba {
> > + memory-region = <&mba_region>;
> > + };
> > +
> > + mpss {
> > + memory-region = <&mpss_region>;
> > + };
> > +
> > + glink-edge {
> > + interrupts = <GIC_SPI 449 IRQ_TYPE_EDGE_RISING>;
> > + label = "modem";
> > + qcom,remote-pid = <1>;
> > + mboxes = <&apss_shared 12>;
> > + };
> > + };
> > +
> > sdhc_2: sdhci@8804000 {
>
> Can you please sort by unit address now that you have a device tree
> that has more stuff?
>
Of course, sorry for missing that.
Regards,
Bjorn
prev parent reply other threads:[~2019-01-23 1:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 5:51 [PATCH v3 00/10] Qualcomm AOSS QMP driver and modem dts Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 01/10] arm64: dts: qcom: sdm845: Update PIL region memory map Bjorn Andersson
2019-01-22 18:58 ` Stephen Boyd
2019-01-22 19:24 ` Bjorn Andersson
2019-01-22 23:10 ` Doug Anderson
2019-01-23 0:30 ` Bjorn Andersson
2019-01-22 23:16 ` Doug Anderson
2019-01-23 0:39 ` Bjorn Andersson
2019-01-25 17:40 ` Sibi Sankar
2019-01-22 5:51 ` [PATCH v3 02/10] arm64: dts: qcom: sdm845: Define rmtfs memory Bjorn Andersson
2019-01-22 23:26 ` Doug Anderson
2019-01-22 23:34 ` Brian Norris
2019-01-23 0:47 ` Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes Bjorn Andersson
2019-01-22 23:46 ` Doug Anderson
2019-01-23 0:26 ` Bjorn Andersson
2019-01-23 0:40 ` Doug Anderson
2019-01-23 1:09 ` Bjorn Andersson
2019-01-23 23:24 ` Doug Anderson
2019-01-24 6:22 ` Stephen Boyd
2019-01-22 5:51 ` [PATCH v3 04/10] dt-bindings: soc: qcom: Add AOSS QMP binding Bjorn Andersson
2019-01-22 19:04 ` Stephen Boyd
2019-01-22 19:25 ` Bjorn Andersson
2019-01-22 19:28 ` Stephen Boyd
2019-01-22 5:51 ` [PATCH v3 05/10] soc: qcom: Add AOSS QMP communication driver Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 06/10] soc: qcom: Add AOSS QMP genpd provider Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 07/10] remoteproc: q6v5-mss: Vote for rpmh power domains Bjorn Andersson
2019-01-23 0:01 ` Doug Anderson
2019-01-22 5:51 ` [PATCH v3 08/10] remoteproc: q6v5-mss: Active powerdomain for SDM845 Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 09/10] arm64: dts: qcom: Add AOSS QMP node Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 10/10] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Bjorn Andersson
2019-01-23 0:28 ` Doug Anderson
2019-01-23 1:10 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123011022.GJ31919@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.