All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Zhong <yang.zhong@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, thuth@redhat.com, peter.maydell@linaro.org,
	ehabkost@redhat.com, sameo@linux.intel.com, yang.zhong@intel.com
Subject: [Qemu-devel] [RFC PATCH v4 32/44] build: convert usb.mak to Kconfig
Date: Wed, 23 Jan 2019 14:56:06 +0800	[thread overview]
Message-ID: <20190123065618.3520-33-yang.zhong@intel.com> (raw)
In-Reply-To: <20190123065618.3520-1-yang.zhong@intel.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Instead of including the same list of devices for each target,
let the host controllers select CONFIG_USB and make the devices
default to present whenever USB is available.

Done with the following script:
  while read i; do
     i=${i%=y}; i=${i#CONFIG_}
     sed -i -e'/^config '$i'$/!b' -en \
            -e'a\' -e'    default y\' -e'    depends on USB' \
          `grep -lw $i hw/*/Kconfig`
  done < default-configs/usb.mak

followed by adding "select USB" on the host controllers.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 default-configs/alpha-softmmu.mak       |  1 -
 default-configs/arm-softmmu.mak         |  2 --
 default-configs/hppa-softmmu.mak        |  1 -
 default-configs/i386-softmmu.mak        |  1 -
 default-configs/mips-softmmu-common.mak |  1 -
 default-configs/ppc-softmmu.mak         |  1 -
 default-configs/riscv32-softmmu.mak     |  1 -
 default-configs/riscv64-softmmu.mak     |  1 -
 default-configs/sh4-softmmu.mak         |  1 -
 default-configs/sh4eb-softmmu.mak       |  1 -
 default-configs/sparc64-softmmu.mak     |  1 -
 default-configs/usb.mak                 | 11 -----------
 hw/usb/Kconfig                          | 26 +++++++++++++++++++++++++
 13 files changed, 26 insertions(+), 23 deletions(-)
 delete mode 100644 default-configs/usb.mak

diff --git a/default-configs/alpha-softmmu.mak b/default-configs/alpha-softmmu.mak
index e583177e79..b9239370a6 100644
--- a/default-configs/alpha-softmmu.mak
+++ b/default-configs/alpha-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for alpha-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_SERIAL_ISA=y
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 67dd1d9531..34e07ff9b8 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for arm-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_VGA=y
 CONFIG_NAND=y
@@ -38,7 +37,6 @@ CONFIG_DS1338=y
 CONFIG_PFLASH_CFI01=y
 CONFIG_PFLASH_CFI02=y
 CONFIG_MICRODRIVE=y
-CONFIG_USB=y
 CONFIG_USB_MUSB=y
 CONFIG_USB_EHCI_SYSBUS=y
 CONFIG_PLATFORM_BUS=y
diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak
index 673ae5a7cf..615e1b528f 100644
--- a/default-configs/hppa-softmmu.mak
+++ b/default-configs/hppa-softmmu.mak
@@ -1,4 +1,3 @@
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_SERIAL_ISA=y
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index 4319bcdea3..37b5bf4c77 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -2,7 +2,6 @@
 
 CONFIG_PCI=y
 CONFIG_ISA_BUS=y
-include usb.mak
 include hyperv.mak
 CONFIG_VGA_ISA=y
 CONFIG_VMWARE_VGA=y
diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
index 6d98ff94a7..338e866eaa 100644
--- a/default-configs/mips-softmmu-common.mak
+++ b/default-configs/mips-softmmu-common.mak
@@ -1,6 +1,5 @@
 # Common mips*-softmmu CONFIG defines
 
-include usb.mak
 CONFIG_ISA_BUS=y
 CONFIG_PCI=y
 CONFIG_ESP=y
diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
index c9f1446e0e..8b15d0fae1 100644
--- a/default-configs/ppc-softmmu.mak
+++ b/default-configs/ppc-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for ppc-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_ISA_BUS=y
 
diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak
index 018c017341..a0a1a96f65 100644
--- a/default-configs/riscv32-softmmu.mak
+++ b/default-configs/riscv32-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for riscv-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_VIRTIO_MMIO=y
diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/riscv64-softmmu.mak
index 018c017341..a0a1a96f65 100644
--- a/default-configs/riscv64-softmmu.mak
+++ b/default-configs/riscv64-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for riscv-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_VIRTIO_MMIO=y
diff --git a/default-configs/sh4-softmmu.mak b/default-configs/sh4-softmmu.mak
index 8382504d11..f0d1a6d031 100644
--- a/default-configs/sh4-softmmu.mak
+++ b/default-configs/sh4-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for sh4-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_SERIAL_ISA=y
diff --git a/default-configs/sh4eb-softmmu.mak b/default-configs/sh4eb-softmmu.mak
index a77e1538e9..58e4c6d154 100644
--- a/default-configs/sh4eb-softmmu.mak
+++ b/default-configs/sh4eb-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for sh4eb-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_SERIAL=y
 CONFIG_SERIAL_ISA=y
diff --git a/default-configs/sparc64-softmmu.mak b/default-configs/sparc64-softmmu.mak
index db393d9eb3..5507346006 100644
--- a/default-configs/sparc64-softmmu.mak
+++ b/default-configs/sparc64-softmmu.mak
@@ -1,6 +1,5 @@
 # Default configuration for sparc64-softmmu
 
-include usb.mak
 CONFIG_PCI=y
 CONFIG_M48T59=y
 CONFIG_PTIMER=y
diff --git a/default-configs/usb.mak b/default-configs/usb.mak
deleted file mode 100644
index e42cfeabbe..0000000000
--- a/default-configs/usb.mak
+++ /dev/null
@@ -1,11 +0,0 @@
-CONFIG_USB=y
-CONFIG_USB_TABLET_WACOM=y
-CONFIG_USB_STORAGE_BOT=y
-CONFIG_USB_STORAGE_UAS=y
-CONFIG_USB_STORAGE_MTP=y
-CONFIG_SCSI=y
-CONFIG_USB_SMARTCARD=y
-CONFIG_USB_AUDIO=y
-CONFIG_USB_SERIAL=y
-CONFIG_USB_NETWORK=y
-CONFIG_USB_BLUETOOTH=y
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index f23c542d27..0b8f41040e 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -5,59 +5,85 @@ config USB_UHCI
     bool
     default y
     depends on PCI
+    select USB
 
 config USB_OHCI
     bool
     default y
     depends on PCI
+    select USB
 
 config USB_EHCI
     bool
     default y
     depends on PCI
+    select USB
 
 config USB_EHCI_SYSBUS
     bool
+    select USB
 
 config USB_XHCI
     bool
     default y
     depends on PCI
+    select USB
 
 config USB_XHCI_NEC
     bool
     default y
     depends on PCI
+    select USB
 
 config USB_MUSB
     bool
+    select USB
 
 config TUSB6010
     bool
+    select USB_MUSB
 
 config USB_TABLET_WACOM
     bool
+    default y
+    depends on USB
 
 config USB_STORAGE_BOT
     bool
+    default y
+    depends on USB
 
 config USB_STORAGE_UAS
     bool
+    default y
+    depends on USB
 
 config USB_AUDIO
     bool
+    default y
+    depends on USB
 
 config USB_SERIAL
     bool
+    default y
+    depends on USB
 
 config USB_NETWORK
     bool
+    default y
+    depends on USB
 
 config USB_BLUETOOTH
     bool
+    default y
+    depends on USB
 
 config USB_SMARTCARD
     bool
+    default y
+    depends on USB
 
 config USB_STORAGE_MTP
     bool
+    default y
+    depends on USB
-- 
2.17.1

  parent reply	other threads:[~2019-01-23  7:00 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  6:55 [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 01/44] hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 02/44] build: actually use CONFIG_PAM Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 03/44] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 04/44] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board Yang Zhong
2019-01-23 21:06   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 05/44] hw/m68k/Makefile.objs: Conditionally build boards Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 06/44] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards Yang Zhong
2019-01-23 15:20   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 07/44] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards Yang Zhong
2019-01-23 15:36   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 08/44] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* Yang Zhong
2019-01-23 15:45   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 09/44] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device Yang Zhong
2019-01-23 15:58   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 10/44] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 11/44] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 12/44] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 13/44] hw/nios2/Makefile.objs: Conditionally build nios2 Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 14/44] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards Yang Zhong
2019-01-23 16:11   ` [Qemu-riscv] " Thomas Huth
2019-01-23 16:11     ` Thomas Huth
2019-01-23 21:59     ` [Qemu-riscv] " Alistair Francis
2019-01-23 21:59       ` Alistair Francis
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 15/44] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 16/44] hw/alpha/Makefile.objs: Create CONFIG_* for alpha Yang Zhong
2019-01-23 16:14   ` Thomas Huth
2019-01-23 21:11   ` Richard Henderson
2019-01-24  9:09     ` Thomas Huth
2019-01-24 10:52       ` Paolo Bonzini
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 17/44] hw/cris/Makefile.objs: Create CONFIG_* for cris Yang Zhong
2019-01-23 16:17   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 18/44] hw/hppa/Makefile.objs: Create CONFIG_* for hppa Yang Zhong
2019-01-23 16:23   ` Thomas Huth
2019-01-23 21:15   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 19/44] hw/moxie/Makefile.objs: Conditionally build moxie Yang Zhong
2019-01-23 16:26   ` Thomas Huth
2019-01-23 21:16   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 20/44] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc Yang Zhong
2019-01-23 16:41   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 21/44] hw/tricore/Makefile.objs: Create CONFIG_* for tricore Yang Zhong
2019-01-23 16:43   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 22/44] minikconfig: add parser skeleton Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 23/44] minikconfig: add AST Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 24/44] minikconfig: add semantic analysis Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 25/44] hw/display: make edid configurable Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files Yang Zhong
2019-01-24 14:06   ` Thomas Huth
2019-01-25  2:18     ` Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 27/44] build: switch to Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 28/44] ide: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable Yang Zhong
2019-01-23 14:23   ` Michael S. Tsirkin
2019-01-25  2:10     ` Yang Zhong
2019-01-25  2:43       ` Michael S. Tsirkin
2019-01-25  2:48         ` Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 30/44] build: convert pci.mak to Kconfig Yang Zhong
2019-01-23 21:19   ` Richard Henderson
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 31/44] build: convert sound.mak " Yang Zhong
2019-01-23  6:56 ` Yang Zhong [this message]
2019-01-23 21:19   ` [Qemu-devel] [RFC PATCH v4 32/44] build: convert usb.mak " Richard Henderson
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 33/44] scsi: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 34/44] bluetooth: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 35/44] isa: express dependencies with kconfig Yang Zhong
2019-01-24 12:23   ` Thomas Huth
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 36/44] i386: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 37/44] i2c: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 38/44] ptimer: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 39/44] edid: express dependencies with kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 40/44] hyperv: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 41/44] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-24 12:51   ` Thomas Huth
2019-01-24 13:33     ` Yang Zhong
2019-01-24 14:10     ` Paolo Bonzini
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 42/44] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 43/44] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 44/44] Makefile: only support defconfig Yang Zhong
2019-01-24  1:09 ` [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Paolo Bonzini
2019-01-24  2:00   ` Yang Zhong
2019-01-24  7:39     ` Paolo Bonzini
2019-01-24  2:38   ` BALATON Zoltan
2019-01-24  7:36     ` Paolo Bonzini
2019-01-31 22:15 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123065618.3520-33-yang.zhong@intel.com \
    --to=yang.zhong@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sameo@linux.intel.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.