From: Greg KH <gregkh@linuxfoundation.org>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: arnd@arndb.de, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 4/6] misc/pvpanic: add pvpanic acpi driver
Date: Wed, 23 Jan 2019 08:34:19 +0100 [thread overview]
Message-ID: <20190123073419.GA18917@kroah.com> (raw)
In-Reply-To: <1548258448-62013-5-git-send-email-peng.hao2@zte.com.cn>
On Wed, Jan 23, 2019 at 11:47:26PM +0800, Peng Hao wrote:
> Make pvpanic acpi driver as seperate file and modify code
> in order to adapt the framework.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
> drivers/misc/pvpanic/Kconfig | 9 +++++
> drivers/misc/pvpanic/Makefile | 1 +
> drivers/misc/pvpanic/pvpanic-acpi.c | 77 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 87 insertions(+)
> create mode 100644 drivers/misc/pvpanic/pvpanic-acpi.c
>
> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
> index 3e612c6..d274130 100644
> --- a/drivers/misc/pvpanic/Kconfig
> +++ b/drivers/misc/pvpanic/Kconfig
> @@ -5,3 +5,12 @@ config PVPANIC
> This driver provides support for the pvpanic device. pvpanic is
> a paravirtualized device provided by QEMU; it lets a virtual machine
> (guest) communicate panic events to the host.
> +
> +if PVPANIC
> +
> +config PVPANIC_ACPI
> + tristate "pvpanic acpi driver"
> + depends on ACPI
> + default PVPANIC
Any reason you ignored the review comments I made for your v1
submission?
Please address those comments before you resend this again.
greg k-h
next prev parent reply other threads:[~2019-01-23 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:47 [PATCH V3 0/6] add pvpanic driver framework Peng Hao
2019-01-23 15:47 ` [PATCH V3 1/6] misc/pvpanic: preparing for " Peng Hao
2019-01-23 15:47 ` [PATCH V3 2/6] misc/pvpanic: Add " Peng Hao
2019-01-23 15:47 ` [PATCH V3 3/6] misc/pvpanic: add API for " Peng Hao
2019-01-23 15:47 ` [PATCH V3 4/6] misc/pvpanic: add pvpanic acpi driver Peng Hao
2019-01-23 7:34 ` Greg KH [this message]
2019-01-23 15:47 ` [PATCH V3 5/6] misc/pvpanic: add pvpanic mmio driver Peng Hao
2019-01-23 15:47 ` [PATCH V3 6/6] misc/pvpanic: add new pvpanic pci driver Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123073419.GA18917@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.