From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: David Turner <novalis@novalis.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] t1512: test ambiguous cat-file --batch and --batch-output
Date: Wed, 23 Jan 2019 12:11:17 +0100 [thread overview]
Message-ID: <20190123111117.GS840@szeder.dev> (raw)
In-Reply-To: <20190118222629.3nvcos24gmi6xe4i@dcvr>
On Fri, Jan 18, 2019 at 10:26:29PM +0000, Eric Wong wrote:
> Test the new "ambiguous" result from cat-file --batch and
> --batch-check. This is in t1512 instead of t1006 since
> we need a repo with ambiguous object_id names.
>
> Signed-off-by: Eric Wong <e@80x24.org>
> ---
> t/t1512-rev-parse-disambiguation.sh | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh
> index e4d5b56014..b0819630c9 100755
> --- a/t/t1512-rev-parse-disambiguation.sh
> +++ b/t/t1512-rev-parse-disambiguation.sh
> @@ -388,4 +388,14 @@ test_expect_success C_LOCALE_OUTPUT 'ambiguous commits are printed by type first
> done
> '
>
> +test_expect_success 'cat-file --batch and --batch-check show ambiguous' '
> + echo "0000 ambiguous" >expect &&
> + echo 0000 | git cat-file --batch-check >actual 2>err &&
> + test_cmp expect actual &&
> + grep hint: err &&
> + echo 0000 | git cat-file --batch >actual 2>err &&
> + test_cmp expect actual &&
> + grep hint: err
The 'git cat-file's error message and hints are translated, so they
should be checked by 'test_i18ngrep' instead of plain old grep.
> +'
> +
> test_done
> --
> EW
next prev parent reply other threads:[~2019-01-23 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 3:38 cat-file ambiguity prints "dangling" Eric Wong
2019-01-18 4:46 ` David Turner
2019-01-18 10:45 ` Eric Wong
2019-01-18 16:20 ` David Turner
2019-01-18 22:26 ` [PATCH] t1512: test ambiguous cat-file --batch and --batch-output Eric Wong
2019-01-18 22:29 ` David Turner
2019-01-23 11:11 ` SZEDER Gábor [this message]
2019-01-30 21:33 ` [PATCH v2] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123111117.GS840@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.