From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/4] trace: make systemtap easier to use for simple logging
Date: Wed, 23 Jan 2019 12:00:12 +0000 [thread overview]
Message-ID: <20190123120016.4538-1-berrange@redhat.com> (raw)
This is a followup to
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04173.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04759.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05477.html
Changed in v4:
- Fix license to be GPLv2-or-later (Eric)
- Misc typo fixes (Eric)
Changed in v3:
- g_strndup the QXL log_buf before printing to avoid a race
with guest removing the nul terminator (Stefan)
- Add filtering of PIDs with "-p PID" arg to qemu-trace-stap
- Add a man page for qemu-trace-stap (Eric)
- Remove examples in docs/devel/tracing.txt and just refer
people to the above man page.
- Use strerror(errno) instead of raw errno in vfio traces (Eric/Alex)
- Quote probe wildcards to be shell glob safe (Eric)
- Mention explicitly that it is launched separately from QEMU (Eric)
Changed in v2:
- Fix safety of QXL logging
- Handle format specifier macros is a more reliable manner
- Fix trace-events files missing newline
- Remove use of %m formats
Daniel P. Berrangé (4):
display: ensure qxl log_buf is a nul terminated string
trace: enforce that every trace-events file has a final newline
trace: forbid use of %m in trace event format strings
trace: add ability to do simple printf logging via systemtap
MAINTAINERS | 1 +
Makefile | 10 ++
Makefile.target | 11 +-
docs/devel/tracing.txt | 4 +
hw/display/qxl.c | 14 ++-
hw/display/trace-events | 2 +-
hw/gpio/trace-events | 2 +-
hw/vfio/pci.c | 2 +-
hw/vfio/trace-events | 2 +-
scripts/qemu-trace-stap | 175 +++++++++++++++++++++++++++
scripts/qemu-trace-stap.texi | 140 +++++++++++++++++++++
scripts/tracetool/__init__.py | 6 +
scripts/tracetool/format/log_stap.py | 127 +++++++++++++++++++
13 files changed, 487 insertions(+), 9 deletions(-)
create mode 100755 scripts/qemu-trace-stap
create mode 100644 scripts/qemu-trace-stap.texi
create mode 100644 scripts/tracetool/format/log_stap.py
--
2.20.1
next reply other threads:[~2019-01-23 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 12:00 Daniel P. Berrangé [this message]
2019-01-23 12:00 ` [Qemu-devel] [PATCH v4 1/4] display: ensure qxl log_buf is a nul terminated string Daniel P. Berrangé
2019-01-23 12:00 ` [Qemu-devel] [PATCH v4 2/4] trace: enforce that every trace-events file has a final newline Daniel P. Berrangé
2019-01-23 12:00 ` [Qemu-devel] [PATCH v4 3/4] trace: forbid use of %m in trace event format strings Daniel P. Berrangé
2019-01-23 12:00 ` [Qemu-devel] [PATCH v4 4/4] trace: add ability to do simple printf logging via systemtap Daniel P. Berrangé
2019-01-24 14:22 ` [Qemu-devel] [PATCH v4 0/4] trace: make systemtap easier to use for simple logging Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123120016.4538-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.