From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 7/7] drm/i915/crt: simplify CRT VBT check on pre-VLV/DDI Date: Wed, 23 Jan 2019 20:36:36 +0200 Message-ID: <20190123183636.GH20097@intel.com> References: <20190122082307.4003-1-jani.nikula@intel.com> <20190122082307.4003-7-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 683F06F000 for ; Wed, 23 Jan 2019 18:36:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190122082307.4003-7-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjIsIDIwMTkgYXQgMTA6MjM6MDdBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVGhlIFZCVCBpbnRfY3J0X3N1cHBvcnQgY2FuJ3QgYmUgdHJ1c3RlZCBvbiBlYXJsaWVy IHBsYXRmb3JtcywgYW5kIGlzCj4gYWx3YXlzIHNldCB0byB0cnVlIGluIGludGVsX2Jpb3MuYyBm b3IgcHJlLURESSBhbmQgcHJlLVZMViBwbGF0Zm9ybXMuIFdlCj4gY2FuIHNpbXBsaWZ5IHRoZSBv dXRwdXQgc2V0dXAgYnkgdW5jb25kaXRpb25hbGx5IGNhbGxpbmcKPiBpbnRlbF9jcnRfaW5pdCgp IGZvciB0aGVzZSBwbGF0Zm9ybXMuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlr dWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE1ICsrKystLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZWQzNzgwZjI0NjM4Li5kMzI4NTk5MjQwY2IgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTE0MzgyLDkgKzE0Mzgy LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gIAkJICogaW5jb3JyZWN0IHNoYXJpbmcgb2YgdGhlIFBQUy4KPiAg CQkgKi8KPiAgCQlpbnRlbF9sdmRzX2luaXQoZGV2X3ByaXYpOwo+IC0KPiAtCQlpZiAoZGV2X3By aXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4gLQkJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsK PiArCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4gIAo+ICAJCWRwZF9pc19lZHAgPSBpbnRl bF9kcF9pc19wb3J0X2VkcChkZXZfcHJpdiwgUE9SVF9EKTsKPiAgCj4gQEAgLTE0NDYxLDE3ICsx NDQ1OSwxNCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQl2bHZfZHNpX2luaXQoZGV2X3ByaXYpOwo+ICAJfSBl bHNlIGlmIChJU19QSU5FVklFVyhkZXZfcHJpdikpIHsKPiAgCQlpbnRlbF9sdmRzX2luaXQoZGV2 X3ByaXYpOwo+IC0KPiAtCQlpZiAoZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4gLQkJ CWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPiArCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7 Cj4gIAl9IGVsc2UgaWYgKElTX0dFTl9SQU5HRShkZXZfcHJpdiwgMywgNCkpIHsKPiAgCQlib29s IGZvdW5kID0gZmFsc2U7Cj4gIAo+ICAJCWlmIChJU19NT0JJTEUoZGV2X3ByaXYpKQo+ICAJCQlp bnRlbF9sdmRzX2luaXQoZGV2X3ByaXYpOwo+ICAKPiAtCQlpZiAoZGV2X3ByaXYtPnZidC5pbnRf Y3J0X3N1cHBvcnQpCj4gLQkJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPiArCQlpbnRlbF9j cnRfaW5pdChkZXZfcHJpdik7Cj4gIAo+ICAJCWlmIChJOTE1X1JFQUQoR0VOM19TRFZPQikgJiBT RFZPX0RFVEVDVEVEKSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoInByb2JpbmcgU0RWT0JcbiIpOwo+ IEBAIC0xNDUxMSw5ICsxNDUwNiw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWlmIChJU19JODVYKGRldl9w cml2KSkKPiAgCQkJaW50ZWxfbHZkc19pbml0KGRldl9wcml2KTsKPiAgCj4gLQkJaWYgKGRldl9w cml2LT52YnQuaW50X2NydF9zdXBwb3J0KQo+IC0JCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7 Cj4gLQo+ICsJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPiAgCQlpbnRlbF9kdm9faW5pdChk ZXZfcHJpdik7Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuMjAuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJ bnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK