All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ossama Othman <ossama.othman@intel.com>
To: ell@lists.01.org
Subject: [PATCH 1/2] key: Avoid using C++ keywords as param names.
Date: Wed, 23 Jan 2019 11:06:09 -0800	[thread overview]
Message-ID: <20190123190610.3787-2-ossama.othman@intel.com> (raw)
In-Reply-To: <20190123190610.3787-1-ossama.othman@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Rename the parameter names "public" and "private" to avoid conflicts
with the similarly named C++ keywords.  Addresses compile-time errors
in C++ code that includes <ell/key.h>.
---
 ell/key.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ell/key.h b/ell/key.h
index 024afc6..0107b05 100644
--- a/ell/key.h
+++ b/ell/key.h
@@ -70,16 +70,16 @@ ssize_t l_key_get_payload_size(struct l_key *key);
 
 bool l_key_get_info(struct l_key *key, enum l_key_cipher_type cipher,
 			enum l_checksum_type checksum, size_t *bits,
-			bool *public);
+			bool *_public);
 
 struct l_key *l_key_generate_dh_private(const void *prime_buf,
 					size_t prime_len);
 
-bool l_key_compute_dh_public(struct l_key *generator, struct l_key *private,
+bool l_key_compute_dh_public(struct l_key *generator, struct l_key *_private,
 				struct l_key *prime,
 				void *payload, size_t *len);
 
-bool l_key_compute_dh_secret(struct l_key *other_public, struct l_key *private,
+bool l_key_compute_dh_secret(struct l_key *other_public, struct l_key *_private,
 				struct l_key *prime,
 				void *payload, size_t *len);
 
-- 
2.17.1


  reply	other threads:[~2019-01-23 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 19:06 [PATCH 0/2] Correct ELL header errors included C++ code Ossama Othman
2019-01-23 19:06 ` Ossama Othman [this message]
2019-01-23 19:10   ` [PATCH 1/2] key: Avoid using C++ keywords as param names Denis Kenzior
2019-01-23 19:06 ` [PATCH 2/2] unit: Added a minimal C++ build test Ossama Othman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123190610.3787-2-ossama.othman@intel.com \
    --to=ossama.othman@intel.com \
    --cc=ell@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.