From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "Input: olpc_apsp - enable the SP clock"
Date: Wed, 23 Jan 2019 14:05:45 -0800 [thread overview]
Message-ID: <20190123220545.GD179701@dtor-ws> (raw)
In-Reply-To: <20190121062255.551587-2-lkundrak@v3.sk>
On Mon, Jan 21, 2019 at 07:22:54AM +0100, Lubomir Rintel wrote:
> Turns out this is not such a great idea. Once the SP clock is disabled,
> it's not sufficient to just enable in order to bring the SP core back up.
>
> It seems that the kernel has no business managing this clock. Just let
> the firmware keep it enabled.
>
> This reverts commit ed22cee91a88c47e564478b012fdbcb079653499.
>
> Link: https://lore.kernel.org/lkml/154783267051.169631.3197836544646625747@swboyd.mtv.corp.google.com/
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
OK, as clock folks say it is a bad idea it must be so. Merge though clk
tree?
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-01-23 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 6:22 [PATCH 0/3] Stop managing the SP clock Lubomir Rintel
2019-01-21 6:22 ` [PATCH 1/3] Revert "Input: olpc_apsp - enable the SP clock" Lubomir Rintel
2019-01-23 22:05 ` Dmitry Torokhov [this message]
2019-01-24 18:53 ` Stephen Boyd
2019-01-24 18:55 ` Stephen Boyd
2019-01-24 18:55 ` Stephen Boyd
2019-01-21 6:22 ` [PATCH 2/3] Revert "clk: mmp2: add " Lubomir Rintel
2019-01-24 18:56 ` Stephen Boyd
2019-01-24 18:56 ` Stephen Boyd
2019-01-21 6:22 ` [PATCH 3/3] Revert "dt-bindings: marvell,mmp2: Add clock id for the " Lubomir Rintel
2019-01-24 18:56 ` Stephen Boyd
2019-01-24 18:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123220545.GD179701@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.