From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM
Date: Wed, 23 Jan 2019 14:07:35 -0800 [thread overview]
Message-ID: <20190123220735.GE179701@dtor-ws> (raw)
In-Reply-To: <CAO-hwJLMKyOeuFyCyaR+zO9BNTDA1pXe35yRF_4nK7ZpOY=3GQ@mail.gmail.com>
On Mon, Jan 21, 2019 at 11:41:32AM +0100, Benjamin Tissoires wrote:
> On Mon, Jan 21, 2019 at 11:11 AM Jiri Kosina <jikos@kernel.org> wrote:
> >
> > On Fri, 18 Jan 2019, Dmitry Torokhov wrote:
> >
> > > It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
> > > folks have used them to indicate switch to full screen mode. Later, they
> > > converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
> > > to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
> > >
> > > Let's commit to these uses, and define:
> > >
> > > - KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
> > > - KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > ---
> > >
> > > Please let me know how we want merge this. Some of patches can be applied
> > > independently and I tried marking them as such, but some require new key
> > > names from input.h
> >
> > Acked-by: Jiri Kosina <jkosina@suse.cz>
>
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Mauro, any objections on pushing the media doc patch through my tree?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-01-23 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 23:30 [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 2/7] [media] doc-rst: switch to new names for Full Screen/Aspect keys Dmitry Torokhov
2019-02-18 7:26 ` Dmitry Torokhov
2019-03-21 12:20 ` Mauro Carvalho Chehab
2019-01-18 23:30 ` [PATCH 3/7] HID: input: fix mapping of aspect ratio key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 4/7] HID: input: add mapping for Expose/Overview key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 5/7] HID: input: add mapping for keyboard Brightness Up/Down/Toggle keys Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 6/7] HID: input: add mapping for "Full Screen" key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 7/7] HID: input: add mapping for "Toggle Display" key Dmitry Torokhov
2019-01-21 10:11 ` [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Jiri Kosina
2019-01-21 10:41 ` Benjamin Tissoires
2019-01-23 22:07 ` Dmitry Torokhov [this message]
2019-03-21 12:17 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123220735.GE179701@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.