From: Matt McCoy <mattmccoy110@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Quytelda Kahja <quytelda@tamalin.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: remove unnecessary parentheses
Date: Wed, 23 Jan 2019 17:21:31 -0500 [thread overview]
Message-ID: <20190123222131.GA10543@mmccoy> (raw)
In-Reply-To: <de570801f163a8d4972661ef794e910a8e1beed5.camel@perches.com>
On Tue, Jan 22, 2019 at 06:45:37PM -0800, Joe Perches wrote:
> On Tue, 2019-01-22 at 21:18 -0500, Matt McCoy wrote:
> > Remove unnecessary parentheses reported by checkpatch.
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> > "- rate_set_size=%d\n",
> > ap->bssid[0], ap->bssid[1], ap->bssid[2],
> > ap->bssid[3], ap->bssid[4], ap->bssid[5],
> > - &(ap->ssid.body[0]),
> > + &ap->ssid.body[0],
> > ap->rate_set.body[0], ap->rate_set.body[1],
> > ap->rate_set.body[2], ap->rate_set.body[3],
> > ap->rate_set.body[4], ap->rate_set.body[5],
>
> This bit:
>
> []
> netdev_dbg(priv->net_dev, "Link AP\n"
> "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
> []
> ap->bssid[0], ap->bssid[1], ap->bssid[2],
>
> should instead use the vsprintf %pM extension
>
> "- bssid: %pM\n"
> []
> ap->bssid,
>
>
Should I just make a v2 of this patch with 2 parts ?
One being this change and the other using the %pM extension.
next prev parent reply other threads:[~2019-01-23 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 2:18 [PATCH] staging: ks7010: remove unnecessary parentheses Matt McCoy
2019-01-23 2:45 ` Joe Perches
2019-01-23 22:21 ` Matt McCoy [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-30 12:48 Joel Camilo Chang Gonzalez
2023-03-30 12:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123222131.GA10543@mmccoy \
--to=mattmccoy110@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.