From: Christoph Hellwig <hch@lst.de>
To: Joerg Roedel <joro@8bytes.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jfehlig@suse.com,
jon.grimm@amd.com, brijesh.singh@amd.com, jroedel@suse.de
Subject: Re: [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size()
Date: Thu, 24 Jan 2019 09:47:48 +0100 [thread overview]
Message-ID: <20190124084748.GA19510@lst.de> (raw)
In-Reply-To: <20190124082431.GH32526@8bytes.org>
On Thu, Jan 24, 2019 at 09:24:31AM +0100, Joerg Roedel wrote:
> On Wed, Jan 23, 2019 at 10:28:13PM +0100, Christoph Hellwig wrote:
> > On Wed, Jan 23, 2019 at 05:30:45PM +0100, Joerg Roedel wrote:
> > > +extern size_t swiotlb_max_mapping_size(struct device *dev);
> >
> > No need for the extern keyword on function declarations in headers.
>
> Right, but all other function declarations in that header file have
> 'extern' too, so I added it also for that one.
Your patch 3 also doesn't use an extern. And I have to say I
much prefer it that way..
next prev parent reply other threads:[~2019-01-24 8:47 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 16:30 [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-23 16:30 ` [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-23 21:28 ` Christoph Hellwig
2019-01-23 21:28 ` Christoph Hellwig
2019-01-24 8:24 ` Joerg Roedel
2019-01-24 8:24 ` Joerg Roedel
2019-01-24 8:47 ` Christoph Hellwig [this message]
2019-01-24 8:47 ` Christoph Hellwig
2019-01-23 21:28 ` Christoph Hellwig
2019-01-23 16:30 ` Joerg Roedel
2019-01-23 16:30 ` [PATCH 2/5] swiotlb: Add is_swiotlb_active() function Joerg Roedel
2019-01-23 21:27 ` Christoph Hellwig
2019-01-24 8:29 ` Joerg Roedel
2019-01-24 8:29 ` Joerg Roedel
2019-01-24 8:41 ` Christoph Hellwig
2019-01-24 8:41 ` Christoph Hellwig
2019-01-24 8:41 ` Christoph Hellwig
2019-01-24 15:00 ` Joerg Roedel
2019-01-28 17:19 ` Michael S. Tsirkin
2019-01-28 17:19 ` Michael S. Tsirkin
2019-01-24 15:00 ` Joerg Roedel
2019-01-23 21:27 ` Christoph Hellwig
2019-01-23 16:30 ` Joerg Roedel
2019-01-23 16:30 ` [PATCH 3/5] dma: Introduce dma_max_mapping_size() Joerg Roedel
2019-01-23 16:30 ` Joerg Roedel
2019-01-23 21:29 ` Christoph Hellwig
2019-01-23 21:29 ` Christoph Hellwig
2019-01-23 16:30 ` [PATCH 4/5] virtio: Introduce virtio_max_dma_size() Joerg Roedel
2019-01-23 16:30 ` Joerg Roedel
2019-01-23 16:30 ` [PATCH 5/5] virtio-blk: Consider virtio_max_dma_size() for maximum segment size Joerg Roedel
2019-01-23 16:30 ` Joerg Roedel
2019-01-23 21:31 ` Christoph Hellwig
2019-01-23 21:31 ` Christoph Hellwig
2019-01-23 22:25 ` Michael S. Tsirkin
2019-01-23 22:25 ` Michael S. Tsirkin
2019-01-24 8:40 ` Joerg Roedel
2019-01-24 8:42 ` Christoph Hellwig
2019-01-24 8:42 ` Christoph Hellwig
2019-01-24 9:51 ` Joerg Roedel
2019-01-24 9:51 ` Joerg Roedel
2019-01-24 9:51 ` Joerg Roedel
2019-01-28 8:05 ` Christoph Hellwig
2019-01-28 17:14 ` Michael S. Tsirkin
2019-01-29 7:38 ` Christoph Hellwig
2019-01-29 7:38 ` Christoph Hellwig
2019-01-28 17:14 ` Michael S. Tsirkin
2019-01-28 8:05 ` Christoph Hellwig
2019-01-24 8:40 ` Joerg Roedel
2019-01-23 17:09 ` [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB Konrad Rzeszutek Wilk
2019-01-23 17:09 ` Konrad Rzeszutek Wilk
2019-01-23 18:51 ` Michael S. Tsirkin
2019-01-23 18:51 ` Michael S. Tsirkin
2019-01-23 21:14 ` Konrad Rzeszutek Wilk
2019-01-23 21:14 ` Konrad Rzeszutek Wilk
2019-01-28 15:20 ` Michael S. Tsirkin
2019-01-28 15:53 ` Konrad Rzeszutek Wilk
2019-01-28 15:53 ` Konrad Rzeszutek Wilk
2019-01-28 15:53 ` Konrad Rzeszutek Wilk
2019-01-28 15:20 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2019-01-29 8:43 [PATCH 0/5 v4] " Joerg Roedel
2019-01-29 8:43 ` [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-29 17:12 ` Christoph Hellwig
2019-01-29 17:12 ` Christoph Hellwig
2019-01-29 8:43 ` Joerg Roedel
2019-01-30 16:40 [PATCH 0/5 v5] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-30 16:40 ` [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-30 16:40 ` Joerg Roedel
2019-01-31 16:33 [PATCH 0/5 v6] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-31 16:33 ` [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-31 16:33 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124084748.GA19510@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jfehlig@suse.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.