From: Phillip Potter <phil@philpotter.co.uk>
To: Jan Kara <jack@suse.cz>
Cc: mark@fasheh.com, amir73il@gmail.com, viro@zeniv.linux.org.uk,
jlbec@evilplan.org, linux-fsdevel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [RFC][PATCH v5 05/09] ocfs2: use common file type conversion
Date: Thu, 24 Jan 2019 09:29:09 +0000 [thread overview]
Message-ID: <20190124092909.GB25629@pathfinder> (raw)
In-Reply-To: <20190123114803.GB20927@quack2.suse.cz>
On Wed, Jan 23, 2019 at 12:48:03PM +0100, Jan Kara wrote:
> On Mon 21-01-19 00:54:32, Phillip Potter wrote:
> > Deduplicate the ocfs2 file type conversion implementation and remove
> > OCFS2_FT_* definitions - file systems that use the same file types
> > as defined by POSIX do not need to define their own versions and can
> > use the common helper functions decared in fs_types.h and implemented
> > in fs_types.c
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>
> The patch looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
Thank you very much Jan.
Regards,
Phil
prev parent reply other threads:[~2019-01-24 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 0:54 [RFC][PATCH v5 05/09] ocfs2: use common file type conversion Phillip Potter
2019-01-23 11:48 ` [Ocfs2-devel] " Jan Kara
2019-01-23 11:48 ` Jan Kara
2019-01-24 9:29 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124092909.GB25629@pathfinder \
--to=phil@philpotter.co.uk \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.