All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
	<linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: Re: [RFC/RFT PATCH 00/15] crypto: improved skcipher, aead, and hash tests
Date: Thu, 24 Jan 2019 10:22:28 -0800	[thread overview]
Message-ID: <20190124182226.GA10448@gmail.com> (raw)
In-Reply-To: <20190124092359.hvizqdi2ptjdsot7@gondor.apana.org.au>

On Thu, Jan 24, 2019 at 05:23:59PM +0800, Herbert Xu wrote:
> On Thu, Jan 24, 2019 at 09:50:35AM +0100, Ard Biesheuvel wrote:
> >
> > Thanks for yet another round of cleanup
> > 
> > I'll look into these, but I'd like to clarify one thing first.
> > 
> > IIUC, you are trying to deal with the case where a single scatterlist
> > element describes a range that strides two pages, and I wonder if that
> > is a valid use of scatterlists in the first place.
> > 
> > Herbert?
> 
> Yes it is valid.  IIRC the network stack may generate such a
> scatterlist.
> 

Also it can easily happen with kmalloced buffers, e.g.

	buf = kmalloc(10000, GFP_KERNEL);

	[...]

	sg_init_one(&sg, buf, 10000);

- Eric

      parent reply	other threads:[~2019-01-24 18:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 22:49 [RFC/RFT PATCH 00/15] crypto: improved skcipher, aead, and hash tests Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 01/15] crypto: aegis - fix handling chunked inputs Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 02/15] crypto: morus " Eric Biggers
2019-01-31  9:05   ` Ondrej Mosnacek
2019-02-01  5:25     ` Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 03/15] crypto: x86/aegis - fix handling chunked inputs and MAY_SLEEP Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 04/15] crypto: x86/morus " Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 05/15] crypto: x86/aesni-gcm - fix crash on empty plaintext Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 06/15] crypto: ahash - fix another early termination in hash walk Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 07/15] crypto: arm64/aes-neonbs - fix returning final keystream block Eric Biggers
2019-01-24 12:11   ` Ard Biesheuvel
2019-01-23 22:49 ` [RFC/RFT PATCH 08/15] crypto: testmgr - add testvec_config struct and helper functions Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 09/15] crypto: testmgr - introduce CONFIG_CRYPTO_MANAGER_EXTRA_TESTS Eric Biggers
2019-02-01  5:31   ` Herbert Xu
2019-02-01  7:00     ` Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 10/15] crypto: testmgr - implement random testvec_config generation Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing to use testvec_configs Eric Biggers
2019-01-24 12:36   ` Ard Biesheuvel
2019-01-24 13:14     ` Corentin Labbe
2019-01-24 14:09       ` Ard Biesheuvel
2019-01-23 22:49 ` [RFC/RFT PATCH 12/15] crypto: testmgr - convert aead " Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 13/15] crypto: testmgr - convert hash " Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 14/15] crypto: testmgr - check for skcipher_request corruption Eric Biggers
2019-01-23 22:49 ` [RFC/RFT PATCH 15/15] crypto: testmgr - check for aead_request corruption Eric Biggers
2019-01-24  8:48 ` [RFC/RFT PATCH 00/15] crypto: improved skcipher, aead, and hash tests Eric Biggers
2019-01-24  8:50   ` Ard Biesheuvel
2019-01-24  9:23     ` Herbert Xu
2019-01-24 10:16       ` Ard Biesheuvel
2019-01-24 10:20         ` Herbert Xu
2019-01-24 18:22       ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190124182226.GA10448@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.