From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=XBjt=QA=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F0654C282C5
	for <netdev@archiver.kernel.org>; Thu, 24 Jan 2019 18:05:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BF541218AF
	for <netdev@archiver.kernel.org>; Thu, 24 Jan 2019 18:05:07 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="vMAvjsUq"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729130AbfAXSFG (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 24 Jan 2019 13:05:06 -0500
Received: from mail.nic.cz ([217.31.204.67]:33192 "EHLO mail.nic.cz"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727991AbfAXSFG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 24 Jan 2019 13:05:06 -0500
Received: from localhost (unknown [172.20.6.218])
        by mail.nic.cz (Postfix) with ESMTPS id 8960A62E04;
        Thu, 24 Jan 2019 19:05:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default;
        t=1548353104; bh=jeSKZ+puunwrChTcm0lRHCA9rNWgA864KYc8oFFItKo=;
        h=Date:From:To;
        b=vMAvjsUq5+XINkUxJqKvAfVvoO5urajkBFfOUKM8ykQbs7JgNgEtwcY6KyzVDawuo
         /A3TLjtcbM5QWihKhGn92eQvNtSDTGnRgy6Au6Ye1UaRsv18M0TG3own/H96YouyXw
         SHiWdbA7chl9LIKcUh6obB0odjTNHIEMEEKp5+vU=
Date:   Thu, 24 Jan 2019 19:04:51 +0100
From:   Marek Behun <marek.behun@nic.cz>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to
 1000BaseX only on 6390X
Message-ID: <20190124190451.40af3127@nic.cz>
In-Reply-To: <20190124164805.GJ482@lunn.ch>
References: <20190124154309.24987-1-marek.behun@nic.cz>
        <20190124161147.GG482@lunn.ch>
        <20190124172916.66e15b29@nic.cz>
        <20190124164805.GJ482@lunn.ch>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: clamav-milter 0.99.2 at mail
X-Virus-Status: Clean
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

What properties does the cpu port node need to contain to force it?
phy-mode = "2500base-x"; is not enough.
Marek

On Thu, 24 Jan 2019 17:48:05 +0100
Andrew Lunn <andrew@lunn.ch> wrote:

> > yes, I wanted to set the cpu port mode in DTS at first, but if I
> > understood the code correctly (maybe I made a mistake), the CPU port
> > mode is not determined from DTS (since there is no phy). Am I
> > wrong?  
> 
> It should work. I have boards which use it for DSA ports. I'm not sure
> i have a board with it for a CPU port though.
> 
>    Andrew