From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gn2wH-0001up-Ov for mharc-qemu-trivial@gnu.org; Fri, 25 Jan 2019 09:58:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmuZf-0006l5-Of for qemu-trivial@nongnu.org; Fri, 25 Jan 2019 01:02:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmuZe-0006bS-Jw for qemu-trivial@nongnu.org; Fri, 25 Jan 2019 01:02:43 -0500 Received: from mga17.intel.com ([192.55.52.151]:45808) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmuZc-0006ZF-HP; Fri, 25 Jan 2019 01:02:40 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 22:02:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,520,1539673200"; d="scan'208";a="141192374" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.37]) by fmsmga001.fm.intel.com with ESMTP; 24 Jan 2019 22:02:36 -0800 From: Wei Yang To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: mst@redhat.com, laurent@vivier.eu, Wei Yang Date: Fri, 25 Jan 2019 14:01:56 +0800 Message-Id: <20190125060157.29935-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190125060157.29935-1-richardw.yang@linux.intel.com> References: <20190125060157.29935-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.151 X-Mailman-Approved-At: Fri, 25 Jan 2019 09:58:36 -0500 Subject: [Qemu-trivial] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 06:02:44 -0000 Function acpi_table_add_builtin() is now used in no place. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/acpi/core.c | 6 ------ include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index d6f0709691..e9b1a85e54 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -305,12 +305,6 @@ out: static bool acpi_table_builtin = false; -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp) -{ - acpi_table_builtin = true; - acpi_table_add(opts, errp); -} - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index c20ace0d0b..4a8bbaf1b5 100644 --- a/include/hw/acpi/acpi.h +++ b/include/hw/acpi/acpi.h @@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void); uint8_t *acpi_table_next(uint8_t *current); unsigned acpi_table_len(void *current); void acpi_table_add(const QemuOpts *opts, Error **errp); -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp); typedef struct AcpiSlicOem AcpiSlicOem; struct AcpiSlicOem { -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmuZh-0006m9-Bd for qemu-devel@nongnu.org; Fri, 25 Jan 2019 01:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmuZg-0006cw-L6 for qemu-devel@nongnu.org; Fri, 25 Jan 2019 01:02:45 -0500 From: Wei Yang Date: Fri, 25 Jan 2019 14:01:56 +0800 Message-Id: <20190125060157.29935-2-richardw.yang@linux.intel.com> In-Reply-To: <20190125060157.29935-1-richardw.yang@linux.intel.com> References: <20190125060157.29935-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: mst@redhat.com, laurent@vivier.eu, Wei Yang Function acpi_table_add_builtin() is now used in no place. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/acpi/core.c | 6 ------ include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index d6f0709691..e9b1a85e54 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -305,12 +305,6 @@ out: static bool acpi_table_builtin = false; -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp) -{ - acpi_table_builtin = true; - acpi_table_add(opts, errp); -} - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index c20ace0d0b..4a8bbaf1b5 100644 --- a/include/hw/acpi/acpi.h +++ b/include/hw/acpi/acpi.h @@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void); uint8_t *acpi_table_next(uint8_t *current); unsigned acpi_table_len(void *current); void acpi_table_add(const QemuOpts *opts, Error **errp); -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp); typedef struct AcpiSlicOem AcpiSlicOem; struct AcpiSlicOem { -- 2.19.1