From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gmygF-0005Yf-M4 for mharc-qemu-trivial@gnu.org; Fri, 25 Jan 2019 05:25:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmygD-0005W6-8t for qemu-trivial@nongnu.org; Fri, 25 Jan 2019 05:25:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmygC-0005h6-DG for qemu-trivial@nongnu.org; Fri, 25 Jan 2019 05:25:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34658) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmyg9-0005Ok-AL; Fri, 25 Jan 2019 05:25:41 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01D2BBAFE; Fri, 25 Jan 2019 10:25:25 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 445C56BF83; Fri, 25 Jan 2019 10:25:24 +0000 (UTC) Date: Fri, 25 Jan 2019 11:25:22 +0100 From: Igor Mammedov To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Message-ID: <20190125112522.0510ab64@redhat.com> In-Reply-To: <20190125094047.22276-1-dgilbert@redhat.com> References: <20190125094047.22276-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 25 Jan 2019 10:25:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [PATCH] typo: apci->acpi X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 10:25:46 -0000 On Fri, 25 Jan 2019 09:40:46 +0000 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > apci_1_compatible should be acpi_1_compatible. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov > --- > hw/acpi/cpu.c | 2 +- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/cpu.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c > index f10b190019..a0a43fe6b5 100644 > --- a/hw/acpi/cpu.c > +++ b/hw/acpi/cpu.c > @@ -508,7 +508,7 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, > GArray *madt_buf = g_array_new(0, 1, 1); > int arch_id = arch_ids->cpus[i].arch_id; > > - if (opts.apci_1_compatible && arch_id < 255) { > + if (opts.acpi_1_compatible && arch_id < 255) { > dev = aml_processor(i, 0, 0, CPU_NAME_FMT, i); > } else { > dev = aml_device(CPU_NAME_FMT, i); > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 2e21a31f82..d60603abd7 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1847,7 +1847,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base); > } else { > CPUHotplugFeatures opts = { > - .apci_1_compatible = true, .has_legacy_cphp = true > + .acpi_1_compatible = true, .has_legacy_cphp = true > }; > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base, > "\\_SB.PCI0", "\\_GPE._E02"); > diff --git a/include/hw/acpi/cpu.h b/include/hw/acpi/cpu.h > index 89ce172941..62f0278ba2 100644 > --- a/include/hw/acpi/cpu.h > +++ b/include/hw/acpi/cpu.h > @@ -48,7 +48,7 @@ void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > CPUHotplugState *state, hwaddr base_addr); > > typedef struct CPUHotplugFeatures { > - bool apci_1_compatible; > + bool acpi_1_compatible; > bool has_legacy_cphp; > } CPUHotplugFeatures; > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmygA-0005Us-Oc for qemu-devel@nongnu.org; Fri, 25 Jan 2019 05:25:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmyg9-0005d4-IC for qemu-devel@nongnu.org; Fri, 25 Jan 2019 05:25:42 -0500 Date: Fri, 25 Jan 2019 11:25:22 +0100 From: Igor Mammedov Message-ID: <20190125112522.0510ab64@redhat.com> In-Reply-To: <20190125094047.22276-1-dgilbert@redhat.com> References: <20190125094047.22276-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] typo: apci->acpi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org On Fri, 25 Jan 2019 09:40:46 +0000 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > apci_1_compatible should be acpi_1_compatible. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov > --- > hw/acpi/cpu.c | 2 +- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/cpu.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c > index f10b190019..a0a43fe6b5 100644 > --- a/hw/acpi/cpu.c > +++ b/hw/acpi/cpu.c > @@ -508,7 +508,7 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, > GArray *madt_buf = g_array_new(0, 1, 1); > int arch_id = arch_ids->cpus[i].arch_id; > > - if (opts.apci_1_compatible && arch_id < 255) { > + if (opts.acpi_1_compatible && arch_id < 255) { > dev = aml_processor(i, 0, 0, CPU_NAME_FMT, i); > } else { > dev = aml_device(CPU_NAME_FMT, i); > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 2e21a31f82..d60603abd7 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1847,7 +1847,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base); > } else { > CPUHotplugFeatures opts = { > - .apci_1_compatible = true, .has_legacy_cphp = true > + .acpi_1_compatible = true, .has_legacy_cphp = true > }; > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base, > "\\_SB.PCI0", "\\_GPE._E02"); > diff --git a/include/hw/acpi/cpu.h b/include/hw/acpi/cpu.h > index 89ce172941..62f0278ba2 100644 > --- a/include/hw/acpi/cpu.h > +++ b/include/hw/acpi/cpu.h > @@ -48,7 +48,7 @@ void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > CPUHotplugState *state, hwaddr base_addr); > > typedef struct CPUHotplugFeatures { > - bool apci_1_compatible; > + bool acpi_1_compatible; > bool has_legacy_cphp; > } CPUHotplugFeatures; >