From: "Rémi Denis-Courmont" <remi@remlab.net>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: [Qemu-arm] [PATCH 3/3] target/arm: fix decoding of B{,L}RA{A,B}
Date: Fri, 25 Jan 2019 23:49:26 +0200 [thread overview]
Message-ID: <20190125214926.3204-3-remi@remlab.net> (raw)
In-Reply-To: <1648289.tQCHxfjYn9@basile.remlab.net>
From: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
A flawed test lead to the instructions always being treated as
unallocated encodings.
Signed-off-by: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
---
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 4d28a27c3b..c550a3f013 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
if (!dc_isar_feature(aa64_pauth, s)) {
goto do_unallocated;
}
- if (op3 != 2 || op3 != 3) {
+ if ((op3 & ~1) != 2) {
goto do_unallocated;
}
if (s->pauth_active) {
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/3] target/arm: fix decoding of B{,L}RA{A,B}
Date: Fri, 25 Jan 2019 23:49:26 +0200 [thread overview]
Message-ID: <20190125214926.3204-3-remi@remlab.net> (raw)
In-Reply-To: <1648289.tQCHxfjYn9@basile.remlab.net>
From: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
A flawed test lead to the instructions always being treated as
unallocated encodings.
Signed-off-by: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
---
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 4d28a27c3b..c550a3f013 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
if (!dc_isar_feature(aa64_pauth, s)) {
goto do_unallocated;
}
- if (op3 != 2 || op3 != 3) {
+ if ((op3 & ~1) != 2) {
goto do_unallocated;
}
if (s->pauth_active) {
--
2.20.1
next prev parent reply other threads:[~2019-01-25 23:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 21:48 [Qemu-arm] [PATCH 0/3] target/arm: fix PAuth in user mode Rémi Denis-Courmont
2019-01-25 21:48 ` [Qemu-devel] " Rémi Denis-Courmont
2019-01-25 21:49 ` [Qemu-arm] [PATCH 1/3] target/arm: fix AArch64 virtual address space size Rémi Denis-Courmont
2019-01-25 21:49 ` [Qemu-devel] " Rémi Denis-Courmont
2019-01-25 23:29 ` [Qemu-arm] " Richard Henderson
2019-01-25 23:29 ` Richard Henderson
2019-01-26 6:36 ` [Qemu-arm] " Rémi Denis-Courmont
2019-01-26 6:36 ` [Qemu-devel] [Qemu-arm] " Rémi Denis-Courmont
2019-01-26 6:46 ` [Qemu-arm] [Qemu-devel] " Rémi Denis-Courmont
2019-01-26 6:46 ` [Qemu-devel] [Qemu-arm] " Rémi Denis-Courmont
2019-01-26 20:00 ` [Qemu-arm] [Qemu-devel] " Richard Henderson
2019-01-26 20:00 ` [Qemu-devel] [Qemu-arm] " Richard Henderson
2019-01-25 21:49 ` [Qemu-devel] [PATCH 2/3] target/arm: actually enable PAuth in user mode Rémi Denis-Courmont
2019-01-25 23:34 ` [Qemu-arm] " Richard Henderson
2019-01-25 23:34 ` Richard Henderson
2019-01-25 21:49 ` Rémi Denis-Courmont [this message]
2019-01-25 21:49 ` [Qemu-devel] [PATCH 3/3] target/arm: fix decoding of B{,L}RA{A,B} Rémi Denis-Courmont
2019-01-25 23:40 ` [Qemu-arm] [Qemu-devel] [PATCH 3/3] target/arm: fix decoding of B{, L}RA{A, B} Richard Henderson
2019-01-25 23:40 ` Richard Henderson
2019-01-27 19:06 ` [Qemu-arm] " Richard Henderson
2019-01-27 19:06 ` Richard Henderson
2019-01-26 6:52 ` [Qemu-arm] [PATCHv2 1/3] target/arm: fix AArch64 virtual address space size Rémi Denis-Courmont
2019-01-26 6:52 ` [Qemu-devel] " Rémi Denis-Courmont
2019-01-27 18:47 ` Richard Henderson
2019-01-26 6:52 ` [Qemu-arm] [PATCHv2 2/3] target/arm: actually enable PAuth in user mode Rémi Denis-Courmont
2019-01-26 6:52 ` [Qemu-devel] " Rémi Denis-Courmont
2019-01-27 18:48 ` [Qemu-arm] " Richard Henderson
2019-01-27 18:48 ` Richard Henderson
2019-02-01 15:27 ` [Qemu-arm] [PATCH 0/3] target/arm: fix " Peter Maydell
2019-02-01 15:27 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125214926.3204-3-remi@remlab.net \
--to=remi@remlab.net \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.