From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Za8y=QC=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 01764C282C7
	for <netdev@archiver.kernel.org>; Sat, 26 Jan 2019 15:58:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BC446218B0
	for <netdev@archiver.kernel.org>; Sat, 26 Jan 2019 15:58:41 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="a93l+DKY"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726145AbfAZP6k (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 26 Jan 2019 10:58:40 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:56407 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726070AbfAZP6k (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 26 Jan 2019 10:58:40 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=967eBrA/TRefL1PoZ8qF5jyBGjKeMkUmx50Lr6utd+U=; b=a93l+DKYdTLVNodl2kC8AdnkS4
        xjt+I74ZKZaLboXZtKmAG5/CJKSw3EUDvw11Hds02xB8RmkM6eLfFdeeCZAWUs+F4N4TePx1LuusL
        2ZMcKj/dW5Tvl1J4D7jAH2M8tyDVDinR5MVuBooPBbyrARehM6+MxYwFNpHDm5iwXm6A=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gnQLq-0006RI-7X; Sat, 26 Jan 2019 16:58:34 +0100
Date:   Sat, 26 Jan 2019 16:58:34 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Russell King <rmk+kernel@armlinux.org.uk>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "net: phy: marvell: avoid pause mode on
 SGMII-to-Copper for 88e151x"
Message-ID: <20190126155834.GA24361@lunn.ch>
References: <E1gnAtB-0002Cz-Tr@rmk-PC.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1gnAtB-0002Cz-Tr@rmk-PC.armlinux.org.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Jan 25, 2019 at 11:27:57PM +0000, Russell King wrote:
> This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0.
> 
> The original diagnosis was incorrect: it appears that the NIC had
> PHY polling mode enabled, which meant that it overwrote the PHYs
> advertisement register during negotiation.

Hi Russell

The NIC wrote to PHY registers? The NIC reading the PHY in hardware is
bad enough, but changing register as well is not good.

What NIC is this? And do you have further patches to really disable
PHY polling?
 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew