Re: [PATCH 0/3] Add script to detect collisions in commandchars

["Paul E. McKenney" <paulmck@linux.ibm.com>]

On Sun, Jan 27, 2019 at 12:07:32AM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> I mentioned in an earlier patch submission that to add collision
> check of commandchars in fcvextract.pl was on my to-do list.
> 
> It turned out that fcvextract.pl is already complicated and
> I changed my mind to add a separate script to check .fcv files for
> the collisions.
> 
> Patch #1 adds the script as utilities/checkfcv.pl.
> Patch #2 adds the invocations of the script in Makefile. It also
> suppresses the echo of commands in the recipes.
> Patch #3 fixes a couple of collisions detected by the script.
> 
> The two collisions were made by myself.  This automatic check
> looks promising to me.

Looks promising, let's see how it goes -- queued and pushed, thank you!

							Thanx, Paul

>         Thanks, Akira
> --
> Akira Yokosawa (3):
>   Add checkfcv.pl
>   Makefile: Invoke checkfcv.pl in -> .fcv recipes
>   CodeSamples: Fix commandchars collision
> 
>  CodeSamples/defer/route_hazptr.c                   |  2 +-
>  .../formal/litmus/C-ISA2+o-r+a-r+a-r+a-o.litmus    |  2 +-
>  Makefile                                           |  8 ++-
>  utilities/checkfcv.pl                              | 78 ++++++++++++++++++++++
>  4 files changed, 85 insertions(+), 5 deletions(-)
>  create mode 100755 utilities/checkfcv.pl
> 
> -- 
> 2.7.4
>