From: Darren Hart <dvhart@infradead.org>
To: Mattias Jacobsson <2pi@mok.nu>
Cc: andy@infradead.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: wmi: fix potential null pointer dereferences
Date: Sat, 26 Jan 2019 12:43:55 -0800 [thread overview]
Message-ID: <20190126204355.GA13882@wrath> (raw)
In-Reply-To: <20190122200302.19861-1-2pi@mok.nu>
On Tue, Jan 22, 2019 at 09:03:01PM +0100, Mattias Jacobsson wrote:
> In the function wmi_dev_match() there are three variables that
> potentially can result in a null pointer dereference. Namely:
Is this something you have observed? This gets called when a new driver
registered for each unassociated device on the bus, so I'm not
immediately seeing how dev or driver would end up being NULL here.
See: Documentation/driver-model/bus.txt
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2019-01-26 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 20:03 [PATCH] platform/x86: wmi: fix potential null pointer dereferences Mattias Jacobsson
2019-01-22 20:03 ` Mattias Jacobsson
2019-01-26 20:43 ` Darren Hart [this message]
2019-01-27 11:46 ` Mattias Jacobsson
2019-01-27 11:46 ` Mattias Jacobsson
2019-01-27 20:32 ` Andy Shevchenko
2019-01-28 14:38 ` Mattias Jacobsson
2019-01-28 14:38 ` Mattias Jacobsson
2019-01-28 15:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126204355.GA13882@wrath \
--to=dvhart@infradead.org \
--cc=2pi@mok.nu \
--cc=andy@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.