From: Darren Hart <dvhart@infradead.org>
To: Yang Fan <nullptr.cpp@gmail.com>
Cc: ike.pan@canonical.com, andy@infradead.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Fix no_hw_rfkill_list for Lenovo RESCUER R720-15IKBN
Date: Sat, 26 Jan 2019 13:33:50 -0800 [thread overview]
Message-ID: <20190126213350.GA41709@wrath> (raw)
In-Reply-To: <d4974133-580d-9166-f554-7e03bb1948b9@gmail.com>
On Sat, Jan 19, 2019 at 07:16:33PM +0800, Yang Fan wrote:
> Commit ae7c8cba3221 ("platform/x86: ideapad-laptop: add lenovo RESCUER
> R720-15IKBN to no_hw_rfkill_list") added
> DMI_MATCH(DMI_BOARD_NAME, "80WW")
> for Lenovo RESCUER R720-15IKBN.
>
> But DMI_BOARD_NAME does not match 80WW on Lenovo RESCUER R720-15IKBN,
> thus cause Wireless LAN still be hard blocked.
>
> On Lenovo RESCUER R720-15IKBN:
> ~$ cat /sys/class/dmi/id/sys_vendor
> LENOVO
> ~$ cat /sys/class/dmi/id/board_name
> Provence-5R3
> ~$ cat /sys/class/dmi/id/product_name
> 80WW
> ~$ cat /sys/class/dmi/id/product_version
> Lenovo R720-15IKBN
>
> So on Lenovo RESCUER R720-15IKBN:
> DMI_SYS_VENDOR should match "LENOVO",
> DMI_BOARD_NAME should match "Provence-5R3",
> DMI_PRODUCT_NAME should match "80WW",
> DMI_PRODUCT_VERSION should match "Lenovo R720-15IKBN".
>
> Fix it, and in according with other entries in no_hw_rfkill_list,
> use DMI_PRODUCT_VERSION instead of DMI_BOARD_NAME.
>
> Fixes: ae7c8cba3221 ("platform/x86: ideapad-laptop: add lenovo
> RESCUER R720-15IKBN to no_hw_rfkill_list")
> Signed-off-by: Yang Fan <nullptr.cpp@gmail.com>
Thanks for the patch, queued for testing.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2019-01-26 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 11:16 [PATCH v2] platform/x86: ideapad-laptop: Fix no_hw_rfkill_list for Lenovo RESCUER R720-15IKBN Yang Fan
2019-01-26 21:33 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126213350.GA41709@wrath \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nullptr.cpp@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.