From: Scott Bauer <sbauer@plzdonthack.me>
To: David Kozub <zub@linux.fjfi.cvut.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH v3 00/16] block: sed-opal: support shadow MBR done flag and write
Date: Sun, 27 Jan 2019 16:14:49 -0500 [thread overview]
Message-ID: <20190127211449.GP21149@hacktheplanet> (raw)
In-Reply-To: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz>
On Tue, Jan 22, 2019 at 11:31:31PM +0100, David Kozub wrote:
> This patch series extends OPAL support: it adds IOCTL for setting the shadow
> MBR done flag which can be useful for unlocking an OPAL disk on boot and it adds
> IOCTL for writing to the shadow MBR. Also included are some minor fixes and
> improvements.
>
> This series is based on the original work done by Jonas Rabenstein which was
> submitted in March 2018.[1] I tried to apply suggestions made in review on the
> list and do some further improvements.
>
> The most contentious issue in the original series was the IOCTL for shadow MBR
> write but I think no better approach was found[2] so this was not changed. I'm
> open to suggestions.
>
> There is a fork of sed-opal-temp that can use these new IOCTLs.[3] I tested
> these on Samsung 840 EVO and 850 EVO drives, on x86-64 and arm64 systems.
>
> The series applies on v5.0-rc3.
>
> Changes from v2 to v3:
> * review suggestions from Scott Bauer
>
> As Scott suggested I tried to do a more thorough testing, esp. with things like
> wrong passwords/invalid values. I did not observe any crash or unexpected
> behavior.
>
> David Kozub (8):
> block: sed-opal: fix typos and formatting
> block: sed-opal: close parameter list in cmd_finalize
> block: sed-opal: unify cmd start
> block: sed-opal: unify error handling of responses
> block: sed-opal: reuse response_get_token to decrease code duplication
> block: sed-opal: pass steps via argument rather than via opal_dev
> block: sed-opal: don't repeat opal_discovery0 in each steps array
> block: sed-opal: rename next to execute_steps
>
You forgot to send 16/16 again in v3. I pulled and tested off your github page.
If you send a v4 or just resend that patch you can add my reviewed-by, as I reviewed it
on my tree/from your github.
next prev parent reply other threads:[~2019-01-27 21:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 22:31 [PATCH v3 00/16] block: sed-opal: support shadow MBR done flag and write David Kozub
2019-01-22 22:31 ` [PATCH v3 01/16] block: sed-opal: fix typos and formatting David Kozub
2019-01-27 21:03 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 02/16] block: sed-opal: use correct macro for method length David Kozub
2019-01-27 21:04 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 03/16] block: sed-opal: unify space check in add_token_* David Kozub
2019-01-27 21:04 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 04/16] block: sed-opal: close parameter list in cmd_finalize David Kozub
2019-01-27 21:05 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 05/16] block: sed-opal: unify cmd start David Kozub
2019-01-27 21:05 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 06/16] block: sed-opal: unify error handling of responses David Kozub
2019-01-27 21:05 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 07/16] block: sed-opal: reuse response_get_token to decrease code duplication David Kozub
2019-01-27 21:06 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 08/16] block: sed-opal: print failed function address David Kozub
2019-01-27 21:06 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 09/16] block: sed-opal: split generation of bytestring header and content David Kozub
2019-01-27 21:07 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 10/16] block: sed-opal: add ioctl for done-mark of shadow mbr David Kozub
2019-01-27 21:07 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 11/16] block: sed-opal: ioctl for writing to " David Kozub
2019-01-27 21:08 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 12/16] block: sed-opal: unify retrieval of table columns David Kozub
2019-01-27 21:08 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 13/16] block: sed-opal: check size of shadow mbr David Kozub
2019-01-27 21:08 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 14/16] block: sed-opal: pass steps via argument rather than via opal_dev David Kozub
2019-01-27 21:09 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array David Kozub
2019-01-27 21:10 ` Scott Bauer
2019-01-22 22:31 ` [PATCH v3 16/16] block: sed-opal: rename next to execute_steps David Kozub
2019-01-27 21:14 ` Scott Bauer [this message]
2019-01-28 8:27 ` [PATCH v3 00/16] block: sed-opal: support shadow MBR done flag and write David Kozub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127211449.GP21149@hacktheplanet \
--to=sbauer@plzdonthack.me \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zub@linux.fjfi.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.