From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 28 Jan 2019 03:42:49 -0000 Received: from mga03.intel.com ([134.134.136.65]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gnxou-0002Lr-6N for speck@linutronix.de; Mon, 28 Jan 2019 04:42:48 +0100 Date: Sun, 27 Jan 2019 19:42:45 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v5 14/27] MDSv5 3 Message-ID: <20190128034245.GL6118@tassilo.jf.intel.com> References: <8b89fce6dd87638a00078082141d3ce5fe13d0ea.1547858934.git.ak@linux.intel.com> <20190123013525.GX6118@tassilo.jf.intel.com> <20190123160206.GZ6118@tassilo.jf.intel.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > +Most interrupt handlers for modern devices should not touch > > +user data, because they rely on DMA and only manipulate > > +pointers. This needs auditing to confirm though. > > Oh well. It's not really hard to write up analysis scripts to filter out > which interrupt handlers are merily doing trivial stuff like > napi_schedule(), schedule_work() etc. You keep saying that, but it's not what I see. I've been going through interrupt handlers the last few days, and I haven't done most of them yet, and I find it certainly not easy because most of them are doing non trivial stuff, and in many cases even use significant indirection and you have to go through many files to find all the code and double check it. But if your magic scripts can all do it then please just send a list. This will save a lot of work for me. Also please do it for tasklets and the other cases. If you can't supply that list please stop spewing such nonsense. I found some incredible bad code so far, including a recursive interrupt handler. At least for the ones I looked at the majority seem to be white listable. But it will take more time to confirm all, not even starting with tasklets yet. Thanks, -Andi