From: Greg KH <greg@kroah.com>
To: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] : net : hso : unregister_netdev only if it has been registered
Date: Mon, 28 Jan 2019 08:07:54 +0100 [thread overview]
Message-ID: <20190128070754.GA2091@kroah.com> (raw)
In-Reply-To: <1548620073263.88642@ece.ufl.edu>
On Sun, Jan 27, 2019 at 08:14:33PM +0000, Yavuz, Tuba wrote:
>
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
>
> Reported-by: Tuba Yavuz <tuba@ece.ufl.edu>
> Signed-off-by: Tuba Yavuz <tuba@ece.ufl.edu>
No need for a reported-by if you wrote the patch and sign off on it.
> ---
>
>
> --- drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500
> +++ drivers/net/usb/hso.c 2019-01-27 14:47:43.592683629 -0500
Your patches need to be one more level deep. Please see the
documentatino for how to do this, git should also create this
automatically correctly for you.
thanks,
greg k-h
prev parent reply other threads:[~2019-01-28 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 20:14 [PATCH] : net : hso : unregister_netdev only if it has been registered Yavuz, Tuba
2019-01-28 7:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128070754.GA2091@kroah.com \
--to=greg@kroah.com \
--cc=netdev@vger.kernel.org \
--cc=tuba@ece.ufl.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.