All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fs/common.mk: enable multithreaded xz compression
Date: Mon, 28 Jan 2019 09:23:16 +0100	[thread overview]
Message-ID: <20190128092316.66c4eaa0@windsurf> (raw)
In-Reply-To: <87a7jln4bt.fsf@dell.be.48ers.dk>

On Sun, 27 Jan 2019 23:06:14 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

>  > Does it matter than the output of -T 0 and -T 1 are identical ?  
> 
> It would cause an extra change in output between buildroot versions
> using -T 0 and ones using -T 1 - But OK, probably that isn't really
> important given all the other changes.

Well, BR2_REPRODUCIBLE is definitely not about guaranteeing identical
output between Buildroot versions. How could this even work, since we
are bumping the version of dozens/hundreds of packages ?

BR2_REPRODUCIBLE is about given a fixed Buildroot version and
configuration, be able to generate a binary-identical result.

>  > What matters for BR2_REPRODUCIBLE=y is if the same input, with -T 0,
>  > always provide the exact identical output.  
> 
> With the new patch that only enables -T 1 for !reproducible builds,
> that is correct.

I thought -T 0 was the problematic thing as it enabled automatic
parallelization, while -T 1 explicitly disabled parallelization.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-01-28  8:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  2:07 [Buildroot] [PATCH 1/1] fs/common.mk: enable multithreaded xz compression james.hilliard1 at gmail.com
2019-01-21 14:02 ` Matthew Weber
2019-01-21 14:05   ` James Hilliard
2019-01-21 14:28     ` [Buildroot] [External] " Matthew Weber
2019-01-21 17:39     ` [Buildroot] " Peter Korsgaard
2019-01-21 21:34       ` James Hilliard
2019-01-26 14:06       ` Thomas Petazzoni
2019-01-26 19:31         ` James Hilliard
2019-01-27 22:06         ` Peter Korsgaard
2019-01-27 22:15           ` James Hilliard
2019-01-27 22:18           ` Peter Korsgaard
2019-01-28  8:23           ` Thomas Petazzoni [this message]
2019-01-28  8:25             ` James Hilliard
2019-01-28  8:57             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128092316.66c4eaa0@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.