From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA054C282C8 for ; Mon, 28 Jan 2019 09:27:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A9BF20880 for ; Mon, 28 Jan 2019 09:27:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZJLz9UfC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A9BF20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f5Gte7TZmZSt8HmMz97Aefy+vKVzPghxseHwpHkmQow=; b=ZJLz9UfCughLja ptthko+Aq6oG1nXPuDX49TITsmS6+U0eXd3rpAuHb6A92cqa/I8lMZ7+Ma2JB9GESp2WAd23Yplwo nnMLIXLZBUjNmabWL5lLOUDUpDxllBupyHroTowFUxsvjkLLltQVo/OnQdqRye5NiciP17iqEVdwl fyrLrBqjOikScRaMwlS/1ezWl61tvjTLiDnF7IQzZSXqv1XL579WsseDt0+zeBa1pxfhsTkkdL+kf QWORcyKO37HuvQJOOd1Xaq17tXVmPFJrbmu45dhBC0Sa/Pw3j9oqc5hjaG+ItL57hX70SjQ5IeK7k WUFRnmbjZmzX1OmDv/ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1go3Cv-0003Ji-7n; Mon, 28 Jan 2019 09:27:57 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1go3Cs-0003JO-1n for linux-mtd@lists.infradead.org; Mon, 28 Jan 2019 09:27:55 +0000 X-Originating-IP: 90.88.29.206 Received: from xps13 (aaubervilliers-681-1-87-206.w90-88.abo.wanadoo.fr [90.88.29.206]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id BD00F1BF206; Mon, 28 Jan 2019 09:27:41 +0000 (UTC) Date: Mon, 28 Jan 2019 10:27:39 +0100 From: Miquel Raynal To: Naga Sureshkumar Relli Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Message-ID: <20190128102720.70a52da7@xps13> In-Reply-To: References: <1541739641-17789-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <20181120120244.7d2442b5@bbrezillon> <20181120133624.3fa4742d@xps13> <20181212091135.1d0cc9a6@xps13> <20181212100931.149b0cac@xps13> <20181212141825.69711c57@xps13> <20181217174114.24196d17@xps13> <20181219152647.76f77711@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190128_012754_240614_598A3C2A X-CRM114-Status: UNSURE ( 9.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "robh@kernel.org" , "martin.lund@keep-it-simple.com" , "richard@nod.at" , "linux-kernel@vger.kernel.org" , Boris Brezillon , "linux-mtd@lists.infradead.org" , "nagasuresh12@gmail.com" , Michal Simek , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "marek.vasut@gmail.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTmFnYSwKCk5hZ2EgU3VyZXNoa3VtYXIgUmVsbGkgPG5hZ2FzdXJlQHhpbGlueC5jb20+IHdy b3RlIG9uIE1vbiwgMjggSmFuIDIwMTkKMDY6MDQ6NTMgKzAwMDA6Cgo+IEhpIEJvcmlzICYgTWlx dWVsLAo+IAo+IENvdWxkIHlvdSBwbGVhc2UgcHJvdmlkZSB5b3VyIHRob3VnaHRzIG9uIHRoaXMg ZHJpdmVyIHRvIHN1cHBvcnQgSFctRUNDPwo+IEFzIEkgc2FpZCBwcmV2aW91c2x5LCB0aGVyZSBp cyBubyB3YXkgdG8gZGV0ZWN0IGVycm9ycyBiZXlvbmQgTiBiaXQuCj4gSSBhbSBvayB0byB1cGRh dGUgdGhlIGRyaXZlciBiYXNlZCBvbiB5b3VyIGlucHV0cy4KCldlIHdvbid0IHN1cHBvcnQgdGhl IEVDQyBlbmdpbmUuIEl0IHNpbXBseSBjYW5ub3QgYmUgdXNlZCByZWxpYWJseS4KCkkgYW0gd29y a2luZyBvbiBhIGdlbmVyaWMgRUNDIGVuZ2luZSBvYmplY3QuIEl0J3MgZ29ubmEgdGFrZSBhIGZl dwptb250aHMgdW50aWwgaXQgZ2V0cyBtZXJnZWQgYnV0IGFmdGVyIHRoYXQgeW91IGNvdWxkIHVw ZGF0ZSB0aGUKY29udHJvbGxlciBkcml2ZXIgdG8gZHJvcCBhbnkgRUNDLXJlbGF0ZWQgZnVuY3Rp b24uIEFsdGhvdWdoIHRoZSBFQ0MKZW5naW5lIHBhcnQgaXMgYmxvY2tpbmcsIHJhdyBhY2Nlc3Mg c3RpbGwgbG9vayB3cm9uZyBhbmQgdGhlIGRyaXZlcgpzdGlsbCBuZWVkcyBjaGFuZ2VzLgoKClRo YW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AC4C282C8 for ; Mon, 28 Jan 2019 09:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39E0E20880 for ; Mon, 28 Jan 2019 09:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbfA1J1r convert rfc822-to-8bit (ORCPT ); Mon, 28 Jan 2019 04:27:47 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42091 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbfA1J1q (ORCPT ); Mon, 28 Jan 2019 04:27:46 -0500 X-Originating-IP: 90.88.29.206 Received: from xps13 (aaubervilliers-681-1-87-206.w90-88.abo.wanadoo.fr [90.88.29.206]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id BD00F1BF206; Mon, 28 Jan 2019 09:27:41 +0000 (UTC) Date: Mon, 28 Jan 2019 10:27:39 +0100 From: Miquel Raynal To: Naga Sureshkumar Relli Cc: "robh@kernel.org" , "marek.vasut@gmail.com" , "richard@nod.at" , "martin.lund@keep-it-simple.com" , "linux-kernel@vger.kernel.org" , Boris Brezillon , "linux-mtd@lists.infradead.org" , "nagasuresh12@gmail.com" , Michal Simek , "computersforpeace@gmail.com" , "dwmw2@infradead.org" Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Message-ID: <20190128102720.70a52da7@xps13> In-Reply-To: References: <1541739641-17789-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <20181120120244.7d2442b5@bbrezillon> <20181120133624.3fa4742d@xps13> <20181212091135.1d0cc9a6@xps13> <20181212100931.149b0cac@xps13> <20181212141825.69711c57@xps13> <20181217174114.24196d17@xps13> <20181219152647.76f77711@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naga, Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019 06:04:53 +0000: > Hi Boris & Miquel, > > Could you please provide your thoughts on this driver to support HW-ECC? > As I said previously, there is no way to detect errors beyond N bit. > I am ok to update the driver based on your inputs. We won't support the ECC engine. It simply cannot be used reliably. I am working on a generic ECC engine object. It's gonna take a few months until it gets merged but after that you could update the controller driver to drop any ECC-related function. Although the ECC engine part is blocking, raw access still look wrong and the driver still needs changes. Thanks, Miquèl