From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, lizhijian@cn.fujitsu.com,
jan.kiszka@siemens.com, jasowang@redhat.com, pbonzini@redhat.com,
stefanha@redhat.com, zhangckid@gmail.com
Subject: Re: [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT
Date: Mon, 28 Jan 2019 11:39:00 +0100 [thread overview]
Message-ID: <20190128103900.ea6nxhm45u4p5mpd@function> (raw)
In-Reply-To: <8736pdnk7a.fsf@linaro.org>
Alex Bennée, le lun. 28 janv. 2019 10:35:37 +0000, a ecrit:
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> Is there a rationale as to why we should replace QEMU_BUILD_BUG_ON with
> G_STATIC_ASSERT or is it particular to these QEMU_BUILD_BUG_ON
> instances? It would be nice to have a little more context in the commit
> message.
It is yet more work towards moving slirp/ to a separately-maintained
libslirp.
Samuel
next prev parent reply other threads:[~2019-01-28 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 11:46 [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT Samuel Thibault
2019-01-27 12:02 ` Marc-André Lureau
2019-01-27 19:11 ` Richard Henderson
2019-01-28 8:31 ` Stefano Garzarella
2019-01-28 10:35 ` Alex Bennée
2019-01-28 10:39 ` Samuel Thibault [this message]
2019-01-28 11:07 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128103900.ea6nxhm45u4p5mpd@function \
--to=samuel.thibault@gnu.org \
--cc=alex.bennee@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.