From: Oleg Nesterov <oleg@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Vladis Dronov <vdronov@redhat.com>,
Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"3.8+" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] HID: debug: fix the ring buffer implementation
Date: Mon, 28 Jan 2019 12:18:19 +0100 [thread overview]
Message-ID: <20190128111818.GA22143@redhat.com> (raw)
In-Reply-To: <CAO-hwJJGux_5bQJmXgLrcj+v=n3n8hvqXfqPEu60aghYNJSfzw@mail.gmail.com>
On 01/28, Benjamin Tissoires wrote:
>
> Oleg, can you provide some feedback before I push this?
Looks good to me, feel free to add
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
> > + set_current_state(TASK_RUNNING);
I still think that
__set_current_state(TASK_RUNNING);
will look a bit better, but this is really minor.
Oleg.
next prev parent reply other threads:[~2019-01-28 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 17:07 [PATCH v2] HID: debug: fix the ring buffer implementation Vladis Dronov
2019-01-28 9:14 ` Benjamin Tissoires
2019-01-28 11:18 ` Oleg Nesterov [this message]
2019-01-29 9:33 ` Benjamin Tissoires
2019-01-29 10:59 ` Vladis Dronov
[not found] ` <20190129003514.08EB720870@mail.kernel.org>
2019-01-29 9:16 ` Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128111818.GA22143@redhat.com \
--to=oleg@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.