From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 6/7] mt76: beaconing fixes for USB
Date: Mon, 28 Jan 2019 14:44:15 +0100 [thread overview]
Message-ID: <20190128134414.GC9257@localhost.localdomain> (raw)
In-Reply-To: <1548678108-9526-7-git-send-email-sgruszka@redhat.com>
[...]
> +
> +void mt76x02_mac_set_beacon_enable(struct mt76x02_dev *dev,
> + struct ieee80211_vif *vif, bool val)
> +{
> + u8 vif_idx = ((struct mt76x02_vif *)vif->drv_priv)->idx;
> + struct sk_buff *skb = NULL;
> +
> + if (mt76_is_mmio(dev))
> + tasklet_disable(&dev->pre_tbtt_tasklet);
> + else
> + skb = ieee80211_beacon_get(mt76_hw(dev), vif);
I guess we can avoid to allocate the skb here if we are disabling 'beaconing'
> +
> + __mt76x02_mac_set_beacon_enable(dev, vif_idx, val, skb);
> +
> + if (mt76_is_mmio(dev))
> + tasklet_enable(&dev->pre_tbtt_tasklet);
> +}
next prev parent reply other threads:[~2019-01-28 13:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 12:21 [PATCH v2 0/7] mt76x02: Beacon support for USB Stanislaw Gruszka
2019-01-28 12:21 ` [PATCH v2 1/7] mt76x02: use mask for vifs Stanislaw Gruszka
2019-01-28 13:35 ` Lorenzo Bianconi
2019-01-28 14:23 ` Stanislaw Gruszka
2019-01-28 14:31 ` Lorenzo Bianconi
2019-01-28 12:21 ` [PATCH v2 2/7] mt76x02: use commmon add interface for mt76x2u Stanislaw Gruszka
2019-01-28 12:21 ` [PATCH v2 3/7] mt76x02: initialize mutli bss mode when set up address Stanislaw Gruszka
2019-01-28 12:21 ` [PATCH v2 4/7] mt76x02: minor beaconing init changes Stanislaw Gruszka
2019-01-28 12:21 ` [PATCH v2 5/7] mt76x02: init beacon config for mt76x2u Stanislaw Gruszka
2019-01-28 12:21 ` [PATCH v2 6/7] mt76: beaconing fixes for USB Stanislaw Gruszka
2019-01-28 13:44 ` Lorenzo Bianconi [this message]
2019-01-28 12:21 ` [PATCH v2 7/7] mt76x02: enable support for IBSS, AP and MESH Stanislaw Gruszka
2019-01-29 11:47 ` [PATCH v2 0/7] mt76x02: Beacon support for USB Kalle Valo
2019-01-29 11:49 ` Felix Fietkau
2019-01-29 12:07 ` Kalle Valo
2019-01-29 12:10 ` Felix Fietkau
2019-01-29 12:18 ` Kalle Valo
2019-01-29 12:40 ` Lorenzo Bianconi
2019-01-30 8:37 ` Stanislaw Gruszka
2019-01-30 9:16 ` Felix Fietkau
2019-01-30 10:07 ` Stanislaw Gruszka
2019-01-30 15:22 ` Stanislaw Gruszka
2019-02-05 14:58 ` Stanislaw Gruszka
2019-01-30 8:29 ` Stanislaw Gruszka
2019-01-30 9:25 ` Felix Fietkau
2019-01-30 10:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128134414.GC9257@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.