From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Block ns inventory changes during admin
Date: Mon, 28 Jan 2019 17:30:00 +0100 [thread overview]
Message-ID: <20190128163000.GA12288@lst.de> (raw)
In-Reply-To: <20190128160712.GA15302@localhost.localdomain>
On Mon, Jan 28, 2019@09:07:13AM -0700, Keith Busch wrote:
> Sure thing. The reporter is attaching namespaces in a loop. The controller
> does support the NS Change Notification, so that automatically triggers
> the namespace scan_work.
>
> Occasionally the namespace scan_work appends the new namespace to the
> list before the admin command effects handling is completed. The effects
> handling attempts to unfreeze the namespace, but if it unfreezes the
> new one, that request_queue freeze depth will be off and we'll hit the
> warning in blk_mq_unfreeze_queue().
>
> On the next namespace add, we fail to freeze that queue due to the
> previous bad accounting and deadlock waiting for frozen.
Ok, makes sense. Can you fold this into the patch description?
prev parent reply other threads:[~2019-01-28 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 19:48 [PATCH] nvme: Block ns inventory changes during admin Keith Busch
[not found] ` <OF5147C249.BC64CC03-ON0025838D.007F28EE-8625838D.007F6785@notes.na.collabserv.com>
2019-01-25 23:37 ` Keith Busch
[not found] ` <BYAPR04MB45021C05936FF7EF982D579686940@BYAPR04MB4502.namprd04.prod.outlook.com>
2019-01-28 15:36 ` Keith Busch
2019-01-28 7:39 ` Christoph Hellwig
2019-01-28 15:33 ` Keith Busch
2019-01-28 15:58 ` Christoph Hellwig
2019-01-28 16:07 ` Keith Busch
2019-01-28 16:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128163000.GA12288@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.