From: Wolfram Sang <wsa@the-dreams.de>
To: marek.vasut@gmail.com
Cc: linux-mmc@vger.kernel.org,
"Takeshi Saito" <takeshi.saito.xv@renesas.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Simon Horman" <horms+renesas@verge.net.au>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: Fix card initialization failure in high speed mode
Date: Tue, 29 Jan 2019 09:01:56 +0100 [thread overview]
Message-ID: <20190129080156.GB911@kunai> (raw)
In-Reply-To: <20190129054039.15278-1-marek.vasut@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
On Tue, Jan 29, 2019 at 06:40:39AM +0100, marek.vasut@gmail.com wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> This fixes card initialization failure in high speed mode.
>
> If U-Boot uses SDR or HS200/400 mode before starting Linux and Linux
> DT does not enable SDR/HS200/HS400 mode, card initialization fails in
> high speed mode.
>
> It is necessary to initialize SCC registers during card initialization
> phase. HW reset function is registered only for a port with either of
> SDR/HS200/HS400 properties in device tree. If SDR/HS200/HS400 properties
> are not present in device tree, SCC registers will not be reset. In SoC
> that support SCC registers, HW reset function should be registered
> regardless of the configuration of device tree.
>
> Reproduction procedure:
> - Use U-Boot that support MMC HS200/400 mode.
> - Delete HS200/HS400 properties in device tree.
> (Delete mmc-hs200-1_8v and mmc-hs400-1_8v)
> - MMC port works high speed mode and all commands fail.
>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-mmc@vger.kernel.org
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-29 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 5:40 [PATCH] mmc: renesas_sdhi: Fix card initialization failure in high speed mode marek.vasut
2019-01-29 8:01 ` Wolfram Sang [this message]
2019-01-29 8:05 ` Ulf Hansson
2019-01-29 9:56 ` Marek Vasut
2019-01-29 16:31 ` Wolfram Sang
2019-01-30 9:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129080156.GB911@kunai \
--to=wsa@the-dreams.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=takeshi.saito.xv@renesas.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.