All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Prashant Malani <pmalani@chromium.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] seq: arecordmidi: Add num-events option
Date: Tue, 29 Jan 2019 17:45:02 +0900	[thread overview]
Message-ID: <20190129084502.GA9419@workstation> (raw)
In-Reply-To: <CACeCKacREMJDGWNJrdydu3+P1EZ81AyaY0sPfBhuiT11nnvV5A@mail.gmail.com>

Hi,

On Mon, Jan 28, 2019 at 09:34:59PM -0800, Prashant Malani wrote:
> Can I duplicate this in arecordmidi.c ? I'm loath to introduce a
> header, and then refactor axfer/main.c.

I don't mind it.

When parsing string with non-numeric characters, the behaviour of
atoi() is undefined still in C11.

$ cd alsa-utils.git
$ git grep atoi | grep optarg | wc
     39     158    1919

Mmm... Many parts are written without enough care of the undefined
behaviour...


Thanks

Takashi Sakamoto

  reply	other threads:[~2019-01-29  8:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  1:44 [PATCH 1/1] seq: arecordmidi: Add num-events option pmalani
2019-01-29  3:36 ` Takashi Sakamoto
2019-01-29  5:34   ` Prashant Malani
2019-01-29  8:45     ` Takashi Sakamoto [this message]
2019-01-29  9:58       ` pmalani
2019-01-29 16:18       ` Clemens Ladisch
2019-01-29 23:42         ` Prashant Malani
2019-02-04 20:20           ` Prashant Malani
2019-02-11  4:23             ` Prashant Malani
2019-02-11  8:14               ` Takashi Iwai
2019-02-11 10:07                 ` Prashant Malani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129084502.GA9419@workstation \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.