From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B53C4151A for ; Tue, 29 Jan 2019 09:41:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9DD12177E for ; Tue, 29 Jan 2019 09:41:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="PAQclmQV"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="F4mlzkS5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727467AbfA2JlR (ORCPT ); Tue, 29 Jan 2019 04:41:17 -0500 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:49153 "EHLO wnew2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbfA2JlR (ORCPT ); Tue, 29 Jan 2019 04:41:17 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A320617B3; Tue, 29 Jan 2019 04:41:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 29 Jan 2019 04:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=WhtnraskFkpTaQhq3yO/yJnKTwd muwTElRGpxD/y/oI=; b=PAQclmQVtSfPTyJYaozJppKrGrjg2S6k29FiXYU6euv V8zQp62pOCqZpBWFDUkIkFesjYpDbjFJpTbNJw3JtYpEKlVbuK4E/J0TRqLn/fUx jDllJsqBsQCVIs3C81HyOLTtpddWxeMZF5644BwHP1pgVlxMk5PWS/bZs1yZ3BOz je7aEffxcHDtX0HrsqiyS04NQR5Eh4+/AkBvou6ZEIcPtjyg69cb4fMp/UaBxx62 KZHv9kgpz7CgFe7TsnW9XEUnoo9eRjT5LZ8IVjbMXHWRMqWtBFq4VgLW74JS4C39 764ahZkk8l3rj+E9+g1opv+ugbO47Rm/cMLqQ9SwStg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Whtnra skFkpTaQhq3yO/yJnKTwdmuwTElRGpxD/y/oI=; b=F4mlzkS5BlZFRJo+AX89cr 7g84jRHf0fuN4tkjWhQST6T45NZiZRUSL1w1JFNAIqwjfEELxftj+gBrT3vW4NOs BVcMhu9rBrFw6ifIKuHhX/cR0XzRmqOCY7cK3K85a1CVY2R5EGADSfFNlH9b0WJJ Jz2sqfe0J63wK7qdzeBWG2IJICNQfvyy5B8EB7lXf+BTbLHPYq7wKCSrjhZK+wrc litAtLduqeroQdWhT7VOtfMT6LGTG1Ho+/WT2unOChVjM+CGRQeisdbZEtsSt5Xl z1smWorw/wo2TlvcZfq1oOvdfO303AvMFg6HElBoGUo/q9D6/xwPMTw1574Wl0Tg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjedvgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegoufhprghmkfhpucdlfedttd dmnecujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhr vghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekle druddtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 329BF100E5; Tue, 29 Jan 2019 04:41:14 -0500 (EST) Date: Tue, 29 Jan 2019 10:41:12 +0100 From: Greg KH To: Niklas Cassel Cc: davem@davemloft.net, stable@vger.kernel.org, netdev@vger.kernel.org, vinod.koul@linaro.org Subject: Re: Request for stable backport: stmmac: Use correct values in TQS/RQS fields Message-ID: <20190129094112.GA20645@kroah.com> References: <20181219095516.GA7747@centauri.lan> <20190129090955.GA16354@centauri.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129090955.GA16354@centauri.lan> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 29, 2019 at 10:09:55AM +0100, Niklas Cassel wrote: > Adding stable since I see Greg's Sign-off-by on recent backports > to this driver. > > > On Wed, Dec 19, 2018 at 10:55:16AM +0100, Niklas Cassel wrote: > > Hello David, > > > > I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac > > with multiple tx queues. > > > > Backporting the following commit: > > > > commit 52a76235d0c4dd259cd0df503afed4757c04ba1d > > Author: Jose Abreu > > Date: Fri Oct 13 10:58:36 2017 +0100 > > > > net: stmmac: Use correct values in TQS/RQS fields > > > > Currently we are using all the available fifo size in RQS and > > TQS fields. This will not work correctly in multi-queues IP's > > because total fifo size must be splitted to the enabled queues. > > > > Correct this by computing the available fifo size per queue and > > setting the right value in TQS and RQS fields. > > > > Signed-off-by: Jose Abreu > > Cc: David S. Miller > > Cc: Joao Pinto > > Cc: Giuseppe Cavallaro > > Cc: Alexandre Torgue > > Signed-off-by: David S. Miller > > > > > > resolves the issue. > > > > The fix was first included in v4.15 > > $ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d > > v4.15 > > v4.15-rc1 > > v4.15-rc2 > > > > Could you please queue it up for 4.14 stable? Netdev doesn't care about 4.14 anymore, so I'll just take it, thanks. greg k-h